Repository navigation
test: let the restarted silent-stream log end before stopping it - #1112
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
- Coverage 95.53% 95.50% -0.04%
==========================================
Files 61 61
Lines 5935 5935
==========================================
- Hits 5670 5668 -2
- Misses 265 267 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 9, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_streamed_log_sync_stop_returns_on_silent_streamrestarts the log and callsstop()right away. Whenstop()lands before the restarted stream delivers its line, the thread falls back to reading the whole log, which the test doesn't serve. The 500 then goes through the client's retry backoff for longer than the 5 sjoin, and the finalLog redirection stopped due to unexpected errorrecord shows up in thecaplogof a later test on the same xdist worker (failed run).The test now waits for the restarted thread to finish on its own (the released server ends the stream after one line), asserts that it did, and only then calls
stop(). Running the two tests back to back failed 12/12 before the change and passes after it.✍️ Drafted by Claude Code