Skip to content

test: let the restarted silent-stream log end before stopping it #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Oct 10, 2026
Merged

test: let the restarted silent-stream log end before stopping it #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/unit/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,8 +1270,11 @@ def generate_logs() -> Iterator[bytes]:
assert not streaming_thread.is_alive()
restarted_thread = streamed_log.start()
assert restarted_thread is not streaming_thread
streamed_log.stop()
# The released server ends the stream after its line, so the thread finishes on its own. A `stop` before that
# line arrived would read the whole log, which this test does not serve.
restarted_thread.join(timeout=5)
assert not restarted_thread.is_alive()
streamed_log.stop()


@pytest.mark.usefixtures('propagate_stream_logs')
Expand Down
Loading