Repository navigation
feat: add passkey identifier verification support #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
utkrishtsahu
wants to merge
7
commits into
main
Choose a base branch
from
feat/passkey-identifier-verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9478b7a
feat: add passkey identifier verification support
utkrishtsahu 0750a5d
fix(passkey): address review feedback on identifier verification
utkrishtsahu d62794c
docs(passkey): reword verification intro, declare retry limit
utkrishtsahu 22de92b
Merge remote-tracking branch 'origin/main' into feat/passkey-identifi…
utkrishtsahu 6847019
fix(passkey): simplify verification types and retry rule
utkrishtsahu 73836f4
fix(passkey): revert 429 mapping to too_many_attempts
utkrishtsahu 3a2c775
fix(passkey): drop client-side code check, clarify retry cases
utkrishtsahu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
auth0/src/main/java/com/auth0/android/result/PasskeyVerificationMethod.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.auth0.android.result | ||
|
|
||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
| /** | ||
| * An identifier whose ownership must be verified with a one-time code before a passkey signup | ||
| * can complete. | ||
| * | ||
| * Returned in [PasskeyRegistrationChallenge.verificationRequired] and | ||
| * [com.auth0.android.authentication.AuthenticationException.passkeyVerificationRequired]. Use it as | ||
| * the key when passing the collected codes in the `verification` map of | ||
| * [com.auth0.android.authentication.AuthenticationAPIClient.signinWithPasskey]. | ||
| * | ||
| * ```kotlin | ||
| * val verification = mapOf(PasskeyVerificationMethod.EMAIL to emailCode) | ||
| * ``` | ||
| * | ||
| * @property value the value used by the Auth0 Authentication API, e.g. `"email"`. | ||
| */ | ||
| public enum class PasskeyVerificationMethod(public val value: String) { | ||
| /** The user's email address. */ | ||
| @SerializedName("email") | ||
| EMAIL("email"), | ||
|
|
||
| /** The user's phone number. */ | ||
| @SerializedName("phone") | ||
| PHONE("phone") | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.