Repository navigation
fix(server): import request and cookie helpers from @tanstack/start-server-core/request-response - #39
Merged
Conversation
…erver-core/request-response
nandan-bhat
previously approved these changes
Sep 15, 2026
nandan-bhat
changed the title
Lead with the actual failure the subpath avoids: the package root (and the @tanstack/react-start/server barrel that re-exports it) pulls in createStartHandler, whose per-app virtual imports #tanstack-router-entry / #tanstack-start-entry can't be resolved when a downstream app pre-bundles this SDK as a dependency (e.g. Vite's dep optimizer), breaking the consumer's dev/build. Keep the SSR renderer / hydration concern as the secondary reason and align the handlers.ts note with cookie-handler.ts.
Contributor
|
Hi @xeofd , Thanks for the contribution !. The changes look good to me. I have added a small commit with some docs cleanup: 17f378f. It updates the code comments to explain why we import from the I'll get it reviewed by another team member and then merge it. |
Contributor
Author
|
Great thanks! Will note the comments if I raise anything else in future |
nandan-bhat
approved these changes
Sep 15, 2026
Piyush-85
approved these changes
Sep 15, 2026
This was referenced Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Raised an issue here that explains what the problem is, simple PR updating imports for tanstack start methods performing cookie actions or get requests.
References
GitHub Issue/PR number addressed or fixed
Issue number 38
Testing
Unit tests have been updated so mocked imports point to the same place as implementation. No new test coverage added.
Checklist