Repository navigation
fix(deps): require @tanstack/start-server-core ^1.169.8 for the /request-response subpath - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The server entry points import request and cookie helpers from
@tanstack/start-server-core/request-response. This subpath was added in #39 to fix the Vite dependency-optimizer resolve failure in #38. The subpath is only exported by@tanstack/start-server-coreversion 1.169.8 and later. It is not present in 1.169.7 or earlier. But the dependency was still declared as^1.0.0.@tanstack/react-startpins a core version transitively, so a consumer on an older react-start can resolve a core below 1.169.8 that still satisfies^1.0.0. The subpath import then fails at build or runtime.Changes
@tanstack/start-server-coreto^1.169.8inpeerDependenciesanddevDependencies.src/server/cookie-handler.tsimport comment to say the subpath needs core 1.169.8 or later. It previously said the package was "always present", which ignores the version.@tanstack/start-server-coreto the README peer-dependency table.Testing
1.169.8resolves@tanstack/start-server-core/request-response. Core1.169.7fails withERR_PACKAGE_PATH_NOT_EXPORTED.npm run build,npm run lint, andnpm test(311 tests) all pass.References