Skip to content

fix(deps): require @tanstack/start-server-core ^1.169.8 for the /request-response subpath - #41

Merged
nandan-bhat merged 2 commits into
mainfrom
fix/SDK-11335
Sep 29, 2026
Merged

nandan-bhat merged 2 commits into
mainfrom
fix/SDK-11335

Conversation

@nandan-bhat

Copy link
Copy Markdown
Contributor

Description

The server entry points import request and cookie helpers from @tanstack/start-server-core/request-response. This subpath was added in #39 to fix the Vite dependency-optimizer resolve failure in #38. The subpath is only exported by @tanstack/start-server-core version 1.169.8 and later. It is not present in 1.169.7 or earlier. But the dependency was still declared as ^1.0.0.

@tanstack/react-start pins a core version transitively, so a consumer on an older react-start can resolve a core below 1.169.8 that still satisfies ^1.0.0. The subpath import then fails at build or runtime.

Changes

  • Bump @tanstack/start-server-core to ^1.169.8 in peerDependencies and devDependencies.
  • Update the src/server/cookie-handler.ts import comment to say the subpath needs core 1.169.8 or later. It previously said the package was "always present", which ignores the version.
  • Add @tanstack/start-server-core to the README peer-dependency table.

Testing

  • Clean install: core 1.169.8 resolves @tanstack/start-server-core/request-response. Core 1.169.7 fails with ERR_PACKAGE_PATH_NOT_EXPORTED.
  • npm run build, npm run lint, and npm test (311 tests) all pass.

References

@Piyush-85 Piyush-85 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandan-bhat
nandan-bhat merged commit d115e32 into main Sep 29, 2026
5 checks passed
@nandan-bhat
nandan-bhat deleted the fix/SDK-11335 branch September 29, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants