Skip to content

fix(deps): require @tanstack/start-server-core ^1.169.8 for the /request-response subpath #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nandan-bhat merged 2 commits into from
Sep 29, 2026
Merged

fix(deps): require @tanstack/start-server-core ^1.169.8 for the /request-response subpath #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7f6604
fix(deps): require @tanstack/start-server-core ^1.169.8 for the /requ…
nandan-bhat Sep 23, 2026
59b38ee
review: address self review findings
nandan-bhat Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,21 @@ with the rest of the Auth0 ecosystem.
npm install @auth0/auth0-tanstack-start-react
```

This SDK relies on the following peer dependencies, which you install in your own app:
This SDK relies on the following peer dependencies:

| Package | Version |
| --- | --- |
| `react` | `^18.0.0` or `^19.0.0` |
| `react-dom` | `^18.0.0` or `^19.0.0` |
| `@tanstack/react-router` | `^1.0.0` |
| `@tanstack/react-start` | `^1.0.0` |
| `@tanstack/start-server-core` | `^1.169.8` |

You install `react`, `react-dom`, `@tanstack/react-router`, and `@tanstack/react-start` in your own
app. `@tanstack/start-server-core` usually comes in through `@tanstack/react-start`, so you rarely
install it directly, but this SDK imports from it directly and needs at least `1.169.8`. If your
`@tanstack/react-start` resolves an older `@tanstack/start-server-core`, add
`@tanstack/start-server-core@^1.169.8` to your app.

## Package structure

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@
"peerDependencies": {
"@tanstack/react-router": "^1.0.0",
"@tanstack/react-start": "^1.0.0",
"@tanstack/start-server-core": "^1.0.0",
"@tanstack/start-server-core": "^1.169.8",
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},
"devDependencies": {
"@tanstack/react-router": "^1.0.0",
"@tanstack/react-start": "^1.0.0",
"@tanstack/start-server-core": "^1.0.0",
"@tanstack/start-server-core": "^1.169.8",
"@testing-library/react": "^16.0.0",
"@types/node": "^26.3.0",
"@types/react": "^19.0.0",
Expand Down
8 changes: 6 additions & 2 deletions src/server/cookie-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
// during dependency optimization. The roots also drag in the SSR renderer
// (renderRouterToString → react-dom/server), which would bloat a client bundle that
// transitively reaches this module and break hydration. The `/request-response`
// subpath exposes the same helpers with neither problem — and start-server-core is a
// direct dependency of @tanstack/react-start, so it is always present.
// subpath exposes the same helpers with neither problem, but it is only exported by
// @tanstack/start-server-core 1.169.8 and later (it is absent through 1.169.7). That is
// the floor pinned in package.json peerDependencies and devDependencies.
// @tanstack/react-start pins core transitively at an exact version, and older
// react-start releases pin a core below this floor, so do not assume an already-installed
// core is new enough.
import {
getCookie,
getCookies,
Expand Down
Loading