Repository navigation
fix(json): re-quote single-quoted strings correctly in parseJson - #569
Merged
Merged
Conversation
A double quote inside a single-quoted string was copied into the double-quoted result unescaped, and an escaped single quote kept a backslash JSON does not accept, so such input threw. Quoted keys no longer lose their inner quotes either. Fixes CodeQL js/incomplete-sanitization alerts 7 and 8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Maksym Stoianov <stoianov.maksym@gmail.com>
escapeCell escapes backslashes before pipes, and the translated reference tables use it too. The link fix-up in sync-jsdoc-links compares the literal URL instead of building a regexp from it. Generated output is unchanged. Fixes CodeQL alerts 12, 13 (js/incomplete-sanitization) and 17 (js/incomplete-hostname-regexp). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Maksym Stoianov <stoianov.maksym@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open CodeQL alerts:
'say "hi"'and\'failed to parse. 7 tests added, 5 of them failed on the old code.🤖 Generated with Claude Code