Repository navigation
test: cover paginated OWNERS and delayed-review contracts - #555
Open
mrbobbytables wants to merge 1 commit into
Open
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
Exercise approval authorization, automatic reviewer selection, and delayed reviewer timing across page boundaries. Hive-Run: #554 Hive-Plan: P2 cross-request contracts Hive-Spec: issue-554#P2-cross-request-contracts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Open
21 tasks
Member
Author
|
/kind cleanup 🐝 Hive Agent: |
github-actions
Bot
added
kind/cleanup
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Quality review (hold-gated lane, advisory only):
- Reproduced locally at head
941fc5d:vitest run __tests__/bundle/ownersGroups.test.ts __tests__/bundle/blunderbussDelay.test.ts→ 24/24 pass; eslint on the three changed files clean. - The new cases assert the second-page request actually happens (
toHaveLength(2)on team-member / timeline reads), so they would fail ifpaginateregressed rather than passing vacuously. fakeGithub.tsheadersaddition is additive; existingFakeResponsecallers unaffected.git merge-treeagainst open #558 (__tests__/cronJobTest/sweep.test.ts) shows no textual conflict.
No blocking findings.
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 941fc5d
— hive: agent=quality backend=copilot model=claude-fable-5.1
This was referenced Oct 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #554 — implements the paginated cross-request contract section; CI enforcement, release delivery, quality triage, and remaining contract decisions stay open.
Tests
npm test -- --run __tests__/bundle/ownersGroups.test.ts __tests__/bundle/blunderbussDelay.test.tsnpm run lint -- __tests__/bundle/fakeGithub.ts __tests__/bundle/ownersGroups.test.ts __tests__/bundle/blunderbussDelay.test.tsnpm run build— hive: backend=copilot model=gpt-6.1-sol