Skip to content

fix(vaultsfyi): bind execute_step network to the wallet chain - #1410

Closed
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/vaultsfyi-execute-step-network-bind
Closed

fix(vaultsfyi): bind execute_step network to the wallet chain#1410
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/vaultsfyi-execute-step-network-bind

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 8, 2026

Copy link
Copy Markdown

Summary

  • execute_step accepted an agent-chosen network and fetched/executed vaults.fyi actions without checking the connected wallet chain. Sibling claim_rewards already rejects cross-network claims.
  • This PR mirrors that guard: require a supported wallet chainId, and reject when args.network does not match it (before any API call or sendTransaction).

Sibling of #1409 (CDP Permit2 / swap-submit retry). Same dogfood pass, different provider and root. Does not reopen that PR's findings.

Test plan

  • pnpm exec jest --testPathPattern='vaultsfyi/vaultsfyiActionProvider' --coverage=false (28/28)
  • Regression: mismatched args.network vs wallet chain returns the claim_rewards-style error and does not call fetch/sendTransaction
  • Regression: missing wallet chainId returns Invalid network

Made with Cursor

Reject execute_step when args.network differs from the wallet chain,
mirroring the existing claim_rewards guard so agents cannot fetch and
send wrong-network vault calldata on the connected wallet.
@SashaMIT
SashaMIT requested a review from murrlincoln as a code owner August 8, 2026 02:38
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@SashaMIT

Copy link
Copy Markdown
Author

Consolidating our open queue to reduce triage load. Closing this for now; the core set we are keeping open is #1392, #1404, #1405, #1409, #1421, #1423. Happy to reopen or refile this specific fix if a maintainer wants it.

@SashaMIT SashaMIT closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants