Remove the deprecated fifocache.size and querier.ingester-metadata-streaming settings - #7791
Open
CharlieTLe wants to merge 2 commits into
Conversation
dosubot
Bot
added
go
All eight have been past the two-minor deprecation window in v1-guarantees.md for at least three minors, and every one is flag-only with no YAML config option and no effect on behaviour, so removing them cannot change how a running cluster behaves. The only impact is that a command line still passing one now fails at startup. Split out from the deprecation removals that do touch YAML config or behaviour, so an objection to those does not hold these up. docs/blocks-storage/migrate-from-chunks-to-blocks.md stops telling readers to set -querier.ingester-streaming. That guide still references other flags removed years ago (-querier.second-store-engine, -querier.use-second-store-before-time); worth a separate look at whether it should stay at all. Signed-off-by: Charlie Le <charlie_le@apple.com>
…reaming settings Unlike the flag-only removals, both of these have a YAML config option and one of them changes behaviour, so they are split out here. -<prefix>.fifocache.size was deprecated in 1.1.0, five years and twenty-one minors ago. A cache configured only through it now starts with no capacity, because NewFifoCache no longer copies it into MaxSizeItems. -querier.ingester-metadata-streaming defaulted to true and its help text has promised since 1.18.0 that the feature would be always on. The querier now always uses the streaming metadata RPCs, so the non-streaming branches in distributor_queryable.go and the three non-streaming methods on the local Distributor interface are gone. The tests that parameterised over streaming on/off collapse accordingly. Also removes the hidden ingester_streaming YAML field, which had no reader at all - it was left behind when -querier.ingester-streaming was deprecated in 1.17.0. Because Cortex decodes config with UnmarshalStrict, that field was still silently accepted until now. Generated config docs and the JSON schema are regenerated. Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
release-1.22-pr-d2-remove-fifocache-metadata-streaming
branch
from
August 20, 2026 01:18
4d1e4c8 to
5a2456e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for v1.22.0. Refs #5922.
Important
Stacked on #7790. Please merge that first; this branch contains its commit, so the
diff here shows both until it lands. Review the second commit only.
Unlike #7790, both settings here have a YAML config option and one of them changes
behaviour, so they are split out.
-<prefix>.fifocache.sizeDeprecated in 1.1.0 (2020) — twenty-one minors and five years ago.
NewFifoCachenolonger copies it into
MaxSizeItems, so a cache configured only throughsizenow startswith no capacity (and already logs "neither max-size-bytes nor max-size-items is set").
-querier.ingester-metadata-streamingDeprecated in 1.18.0, defaulted to
true, and its help text has promised since thenthat the feature "will be always on after v1.18". The querier now always uses the streaming
metadata RPCs, so this removes:
distributor_queryable.go(Selecton the/seriespath,LabelValues,LabelNames,labelNamesWithMatchers);Distributorinterface(
MetricsForLabelMatchers,LabelValuesForLabelName,LabelNames). The realdistributor keeps them; this only loosens what
pkg/querierrequires, andpkg/apinever called them through the interface.
Also: a dead hidden YAML field
querier.ingester_streaming(doc:"hidden",bool) had no reader anywhere — just thefield declaration. It was left behind when
-querier.ingester-streamingwas deprecated in1.17.0. Because Cortex decodes config with
yaml.UnmarshalStrict, that key was still beingsilently accepted until now.
I put it here rather than in #7790 so that PR stays honestly flag-only. Note this means the
plan's "flag-only" classification of
-querier.ingester-streamingwas slightly off.Generated docs
docs/blocks-storage/querier.md,docs/configuration/config-file-reference.mdandschemas/cortex-config-schema.jsonare regenerated (make doc).Verification
go build ./...,go vet ./...(no new findings),make doc, and./pkg/querier/... ./pkg/chunk/cache/... ./pkg/cortex/... ./pkg/api/...all green.