Repository navigation
feat: add values to turn on ClickHouse test steps storage - #81
Merged
Merged
Conversation
currents.testSteps.dualWriteFrom and onlyFrom render STEPS_CLICKHOUSE_DUAL_WRITE_FROM and STEPS_CLICKHOUSE_ONLY_FROM on the director and the writer from one helper, so both get the same times. currents.testSteps.retentionDays renders STEPS_RETENTION_DAYS on the writer. All three are empty by default and render nothing. The quickstart gets the order to turn it on. It needs Currents images that include currents-dev/currents#5007. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd
|
| Topic | Details | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| Document rollout | Explain how to enable, validate, retain, and roll back ClickHouse test-step storage, and record the new configuration in the changelog and generated values reference.Modified files (3)
Latest Contributors(2)
| |||||||||
| Enable test steps | Configure optional ClickHouse test-step storage by propagating dualWriteFrom and onlyFrom to the director and writer, and retentionDays to the writer. Keep defaults empty so existing installations remain unchanged.Modified files (4)
Latest Contributors(2)
|
Merger ✅ Ready to Merge
MERGE: the chart values, environment wiring, documentation, and changelog deliver the requested ClickHouse test-steps configuration, and the review discussion is settled. CI ran successfully.
The dashboard reads object storage for tests written in dual-write, so it cannot show whether ClickHouse has their steps. Step 4 now queries test_attempt_steps and compares step_count with the object storage file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd
The writer looks up a record's stored expiry and inserts in separate queries, so two writers on different retention values can put one test in two partitions. Changing the value needs all writers stopped first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd
…ntion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd
…writer` The deployment is named after the release, so deploy/currents-writer does not exist for a release called anything else, and the scale to 0 would silently do nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd
twk3
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: @agoldis
Linear: ENG-2238
Do not release before https://github.com/currents-dev/currents/pull/5007 (allow ClickHouse test steps on-prem) ships in a Currents release. Sibling PR for Compose: currents-dev/docker#45.
What and why
Lets a Helm install turn on test steps in ClickHouse. Everything is empty by default and renders nothing: the rendered manifests with default values are identical to
main.currents.testSteps.dualWriteFromandcurrents.testSteps.onlyFromrenderSTEPS_CLICKHOUSE_DUAL_WRITE_FROMandSTEPS_CLICKHOUSE_ONLY_FROM. One helper (currents.testStepsEnv) adds them to thedirectorand thewriter, so both always get the same values.currents.testSteps.retentionDaysrendersSTEPS_RETENTION_DAYSon thewriter(7, 14, 21, 30, 60, 90, 180 or 365; rounded up; default 21 in the app).docs/eks/quickstart.mdhas a new section, "Test Steps in ClickHouse (Optional)", with what each value does and the order to turn it on. The values table indocs/configuration.mdis regenerated.CHANGELOG.mdhas an Unreleased entry. The chart version is not bumped; the release PR does that.Service mapping
directordirectorruns the test record code itself.writerserverai-queue-workerClickHouse access
No template change was needed.
currents.connectionConfigEnvgives every deploymentCLICKHOUSE_URL,CLICKHOUSE_USERNAMEandCLICKHOUSE_PASSWORD(or the access token) fromcurrents.clickhouse. Theserver,ai-queue-workerandwriteralready have them. They can differ only if an install overrides them inglobal.envor a component'senv; the docs tell the operator to check.Checks
helm lint charts/currents -f charts/currents/ci/lint-values.yaml(helm 3.19.0): passed.helm templatewith default values: output identical tomain.helm templatewithdualWriteFrom,onlyFromandretentionDaysset (by--setand by a values file with an unquoted timestamp): bothSTEPS_CLICKHOUSE_*appear ondirectorandwriteronly;STEPS_RETENTION_DAYSonwriteronly.helm-docs:docs/configuration.mdregenerated and committed.ct install(CI does it).🤖 Generated with Claude Code
https://claude.ai/code/session_011baD3jVnrAJyGsQvfW3Bvd