feat(giveback): add weekly leaderboard to the Impact tab#6316
Closed
tsahimatsliah wants to merge 8 commits into
Closed
feat(giveback): add weekly leaderboard to the Impact tab#6316tsahimatsliah wants to merge 8 commits into
tsahimatsliah wants to merge 8 commits into
Conversation
Port the ranked contribution leaderboard (medal podium rows, viewer's tinted row, and a "your rank" recap with the exact gap to the next place) from the original MVP branch into today's architecture, and render it on the Impact tab below the personal roadmap. Standings are placeholder until a backend leaderboard endpoint lands; the data source is isolated in useGivebackLeaderboard so only that hook needs to change. The "You" row is stitched in from the real logged-in profile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Instead of stacking the leaderboard under the personal roadmap on the Impact tab, give it its own "Leaderboard" tab between Impact and Causes. Keeps the Impact tab focused on the personal journey, and reverts the GivebackImpactPanel (and its spec) back to their original state. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…oard # Conflicts: # packages/shared/src/features/giveback/components/GivebackTabNav.spec.tsx # packages/shared/src/features/giveback/components/GivebackTabNav.tsx
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ax-w-2xl) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the ranked weekly leaderboard from the original giveback MVP branch (PR #6139, never merged) into the current giveback page as its own dedicated tab ("Leaderboard", between "Your impact" and "Causes").
Data
There's no backend leaderboard endpoint yet, so standings are placeholder (marked with a
TODO), isolated inuseGivebackLeaderboard— only that hook changes when the endpoint lands. The "You" row is stitched in from the real logged-in profile so it feels personal. The whole surface stays behind the existingfeatureGivebackflag.Where to see it
Storybook: Features/Giveback/Leaderboard.
Notes
leaderboardentry inGivebackTabId/givebackTabs, rendered inGivebackPage; the Impact panel is untouched.🤖 Generated with Claude Code
Preview domain
https://feat-giveback-leaderboard.preview.app.daily.dev