fix(giveback): stop causes-breakdown slices sharing a colour#6317
Closed
tsahimatsliah wants to merge 1 commit into
Closed
fix(giveback): stop causes-breakdown slices sharing a colour#6317tsahimatsliah wants to merge 1 commit into
tsahimatsliah wants to merge 1 commit into
Conversation
cabbage (purple) and bacon (pink) sat next to each other in SLICE_COLORS, so a 4-slice donut painted two slices in near-identical magenta tones (e.g. Open source and Mental health). Reorder the palette so the first slices are maximally distinct hues and the two magenta-family tones sit at opposite ends, so a typical chart never shows both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Jul 14, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the "Where the money will go" donut (
GivebackCausesBreakdown), two slices could render in near-identical magenta tones — e.g. Open source (cabbage, purple#BA56E1) and Mental health (bacon, pink#F25D82) looked like the same colour.Cause:
SLICE_COLORSlisted cabbage and bacon close together (positions 1 and 4), so a typical 4-slice chart painted both.Fix
Reorder the palette so the earliest slices are maximally distinct hues (purple → yellow → blue → green) and the two magenta-family tones (cabbage, bacon) sit at opposite ends. A typical 4–5 slice chart now never shows both, so no two slices read alike. Colours and tokens are unchanged — only their order.
Notes
GivebackCausesBreakdown.spec.tsxpasses (it doesn't assert specific colours).🤖 Generated with Claude Code
Preview domain
https://fix-giveback-breakdown-colors.preview.app.daily.dev