fix: let the fabric identity sweep run without stopping the manager - #18
Merged
Conversation
The sweep added with the per-identity placement policies deletes the per-location policies it replaced, but the federation credential could only create and patch them. The forbidden delete came back from a manager runnable, where an error stops the manager, so the controller crash-looped and nothing was reconciled at all -- worse than the leftover policies it was clearing. Grant the delete the sweep and collect both already needed, and make the sweep best-effort: a policy it cannot remove is logged loudly and the manager still starts. A controller that refuses to run reconciles nothing, where a leftover policy is a correctness problem that is at least visible and recoverable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ecv
approved these changes
Aug 27, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is wrong
fabric-identity-controlleris inCrashLoopBackOffon staging since #17 rolled, so no fabric identity is being reconciled at all.Two mistakes in #17, mine:
create;get;list;patch;update;watchonclusterpropagationpolicies. The sweep deletes, and so doescollectviaunplace, sodeletewas needed and neither path could have worked.What changed
deleteadded to theclusterpropagationpoliciesmarker;config/rbac/role.yamlregenerated withtask generate:rbac(one line).The second change is the one that matters: it makes this class of mistake visible rather than fatal.
Test plan
go build,go vet, fullgo test ./...Runningon staging and the legacycloud-fabric-identity-us-central-1policy is gone