fix: stop the sweep's logger shadowing the log import - #19
Merged
Conversation
Lint fails on main: the local logger in sweepLegacyPlacements is named log, which shadows the controller-runtime log package this file imports. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ecv
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is wrong
Lint is failing on
main:The logger I introduced in
sweepLegacyPlacementsis namedlog, and this file importssigs.k8s.io/controller-runtime/pkg/log. Mine, from #18 — I ran the linter before that change and not after.What changed
Renamed to
logger. Nothing else.Test plan
golangci-lintreports no import-shadowinggo build,go vet, fullgo test ./...