Skip to content

fix: stop the sweep's logger shadowing the log import #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotwells merged 1 commit into from
Aug 27, 2026
Merged

fix: stop the sweep's logger shadowing the log import #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/controller/networkfabricidentity_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,12 +431,12 @@ func (r *NetworkFabricIdentityReconciler) unplace(ctx context.Context, namespace
// a correctness problem worth logging loudly where a controller that will not
// start reconciles nothing at all.
func (r *NetworkFabricIdentityReconciler) sweepLegacyPlacements(ctx context.Context) error {
log := ctrl.LoggerFrom(ctx)
logger := ctrl.LoggerFrom(ctx)

var policies unstructured.UnstructuredList
policies.SetGroupVersionKind(clusterPropagationPolicyGVK.GroupVersion().WithKind("ClusterPropagationPolicyList"))
if err := r.Hub.List(ctx, &policies, client.MatchingLabels{FabricIdentityPolicyLabel: "true"}); err != nil {
log.Error(err, "could not read the fabric identity placement policies to sweep")
logger.Error(err, "could not read the fabric identity placement policies to sweep")
return nil
}

Expand All @@ -446,11 +446,11 @@ func (r *NetworkFabricIdentityReconciler) sweepLegacyPlacements(ctx context.Cont
continue
}
if err := r.Hub.Delete(ctx, policy); err != nil && !apierrors.IsNotFound(err) {
log.Error(err, "could not remove a legacy per-location placement policy, it will keep competing for identities",
logger.Error(err, "could not remove a legacy per-location placement policy, it will keep competing for identities",
"policy", policy.GetName())
continue
}
log.Info("removed a legacy per-location placement policy", "policy", policy.GetName())
logger.Info("removed a legacy per-location placement policy", "policy", policy.GetName())
}
return nil
}
Expand Down
Loading