Repository navigation
test(review): separate pipe EOF from holder process lifetime - #183
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Main CI repeatedly failed an overflow test that equated inherited-pipe EOF with disappearance of a foreign holder PID. Capture completion guarantees pipe closure, while the holder's process lifetime is separate.
What changed
Scope
Three test lines only. Product behavior, package bytes, grader sources, policy, and qualification requirements remain unchanged.
Tradeoffs
The fixture tests the actual pipe-drain contract instead of depending on process exit and OS reaping timing. Existing teardown still terminates the owned holder.
Blast Radius
This removes a timing-dependent CI assertion. It changes no runtime cleanup behavior.
Verification
Deterministic RED fails the old PID-disappearance expectation on both channels. GREEN passes the full 11-test file.
Independent Linux observations show holders in state
Sat EOF and absent after teardown. An early-settlement mutant still fails both preservation-marker checks.Independent maintained packing preserves the exact package and manifest. All 105 grader source files remain unchanged.
Full push preflight passed with 2,912 tests passing, 20 existing skips, and zero failures. Independent exact-head source/package review and comment audit passed.