Skip to content

test(review): separate pipe EOF from holder process lifetime #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vriesd merged 2 commits into from
Oct 8, 2026
Merged

test(review): separate pipe EOF from holder process lifetime #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af609c7
test(review): reproduce pipe closure before holder exit
vriesdcrv Oct 8, 2026
15ba940
test(review): assert pipe lifetime independently of holder PID
vriesdcrv Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/review-diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ test.skipIf(process.platform === "win32")(
);

test.skipIf(process.platform === "win32").each(["stdout", "stderr"] as const)(
"%s overflow kills a TERM-ignoring child and waits for inherited pipes before cleanup",
"%s overflow kills a TERM-ignoring child and waits for pipe EOF while the holder remains alive",
async (channel) => {
const fixture = await fakeGit(`
import {spawn} from "node:child_process";
Expand All @@ -151,7 +151,7 @@ test.skipIf(process.platform === "win32").each(["stdout", "stderr"] as const)(
const holder = join(fixture.directory, "holder.mjs");
await writeFile(
holder,
`import {existsSync,writeFileSync} from "node:fs";writeFileSync(process.env.HOLDER_PID,String(process.pid));writeFileSync(process.env.READY,"ready");setTimeout(()=>{writeFileSync(process.env.MARKER,JSON.stringify(existsSync(process.env.OPERANDS+"/before")&&existsSync(process.env.OPERANDS+"/after")));process.exit(0);},250);`,
`import {closeSync,existsSync,writeFileSync} from "node:fs";writeFileSync(process.env.HOLDER_PID,String(process.pid));writeFileSync(process.env.READY,"ready");setTimeout(()=>{writeFileSync(process.env.MARKER,JSON.stringify(existsSync(process.env.OPERANDS+"/before")&&existsSync(process.env.OPERANDS+"/after")));closeSync(1);closeSync(2);setInterval(()=>{},1000);},250);`,
);
const marker = join(fixture.directory, "marker");
const environment = {
Expand All @@ -173,7 +173,7 @@ test.skipIf(process.platform === "win32").each(["stdout", "stderr"] as const)(
await expect(capture).rejects.toThrow(`${channel} exceeds its capacity`);
expect(
processGone(Number(await readFile(environment.HOLDER_PID, "utf8"))),
).toBe(true);
).toBe(false);
},
);

Expand Down
Loading