Repository navigation
Fix the 2FA Log in button that did nothing on click - #299
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 22, 2026
PhilReinking
left a comment
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 8ba0195 (CI: the PM checks it). @deck9/ui 0.17.0 (lockfile) renders its button with type: "button" (dist/src/ui.mjs:97). type is not a prop, so the passed type="submit" wins, as on Login, Register, ForgotPassword, ResetPassword and VerifyEmail. ConfirmPassword uses JetButton, whose type defaults to "submit". The changelog line is under [Unreleased] → Fixed.
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking "Log in" on the two-factor screen now sends the code. Before, only Enter worked: the button had no
type, and the UI Button defaults totype="button". Fix:type="submit".Other Auth pages already submit on click (ConfirmPassword's Jetstream button defaults to submit).
Tested: new tests click the button with a code and a recovery code, and fail without the fix; lint is clean.
Not tested: a real 2FA login in a browser.
Fixes BITS-388
🤖 Generated with Claude Code