Repository navigation
test: start recording a client API call once its remote video decodes - #443
Merged
Merged
Conversation
A signaled track need not carry video yet, and on a slow runner the recorder then waited past its header timeout for a key frame. Warnings are now part of the failure message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientApiRecorderTest.recordsRemoteTracksfails now and then on macOS arm64 runners with a file that has no video: the recorder waits 3 s for a key frame of the remote video and then starts without it.The call was taken as up once its tracks were signaled, plus a fixed 1.5 s. On a slow runner the receiver could still be waiting for its own first key frame by then. The setup now waits until the remote video decodes before that pause, and the recorder's warnings (such as a track left out) are part of the failure message.