Skip to content

test: start recording a client API call once its remote video decodes #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devopvoid merged 1 commit into from
Oct 25, 2026
Merged

test: start recording a client API call once its remote video decodes #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions webrtc-media/src/test/java/dev/onvoid/webrtc/media/recorder/ClientApiRecorderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import dev.onvoid.webrtc.client.Sender;
import dev.onvoid.webrtc.client.Signaling;
import dev.onvoid.webrtc.client.SignalingPair;
import dev.onvoid.webrtc.client.Subscription;
import dev.onvoid.webrtc.client.WebRtc;
import dev.onvoid.webrtc.client.internal.EncodedFrames;
import dev.onvoid.webrtc.media.player.MediaInfo;
Expand Down Expand Up @@ -124,6 +125,16 @@ void startCall() throws Exception {
remoteVideo.get(15, TimeUnit.SECONDS);
remoteAudio.get(15, TimeUnit.SECONDS);

// A track that is signaled need not carry video yet: on a slow machine
// the receiver may still wait for its first key frame, and a recorder
// started then waits for one too, longer than it holds the file back
// for it. The call is up once the remote video decodes.
CountDownLatch decoded = new CountDownLatch(15);

try (Subscription frames = remoteVideo.join().asVideo().onFrame(frame -> decoded.countDown())) {
assertTrue(decoded.await(15, TimeUnit.SECONDS), "no remote video decoded");
}

// Well into the call, so that the recorder has to ask for a key frame.
Thread.sleep(1500);
}
Expand All @@ -141,14 +152,14 @@ void endCall() throws Exception {
void recordsRemoteTracks() throws Exception {
Path file = tempDir.resolve("received.mkv");

record(file, recorder -> {
List<String> warnings = record(file, recorder -> {
recorder.addTrack(remoteVideo.join());
recorder.addTrack(remoteAudio.join());
});

MediaInfo info = readInfo(file);

assertTrue(info.hasVideo());
assertTrue(info.hasVideo(), () -> "No video, warnings: " + warnings);
assertEquals(WIDTH, info.getVideoWidth());
assertEquals(HEIGHT, info.getVideoHeight());
assertEquals("opus", info.getAudioCodec());
Expand Down Expand Up @@ -242,9 +253,14 @@ private interface Tracks {

}

private static void record(Path file, Tracks tracks) throws Exception {
/**
* Records the given tracks into the file, and returns what the recorder
* warned of, such as a track it had to leave out.
*/
private static List<String> record(Path file, Tracks tracks) throws Exception {
CountDownLatch started = new CountDownLatch(1);
AtomicReference<String> error = new AtomicReference<>();
List<String> warnings = new CopyOnWriteArrayList<>();

try (MediaRecorder recorder = new MediaRecorder(file)) {
recorder.setListener(new MediaRecorderListener() {
Expand All @@ -254,6 +270,11 @@ public void onStarted() {
started.countDown();
}

@Override
public void onWarning(String message) {
warnings.add(message);
}

@Override
public void onError(String message) {
error.set(message);
Expand All @@ -269,6 +290,8 @@ public void onError(String message) {
}

assertNull(error.get());

return warnings;
}

private static MediaInfo readInfo(Path file) throws Exception {
Expand Down
Loading