Own app id com.codedeck.plus + plus-badged icon - #3
Merged
Conversation
The Android identifier was still com.codedeck.next — identical to upstream CodeDeck Next. That made CodeDeck+ un-installable alongside upstream (same package name) and un-installable over it (different signing key -> INSTALL_FAILED_UPDATE_INCOMPATIBLE). The README already claimed "installs side by side", which was untrue. App id -> com.codedeck.plus, distinct from both the original CodeDeck (com.codedeck.app) and upstream CodeDeck Next (com.codedeck.next): - tauri.conf.json identifier; gen/android build.gradle.kts namespace + applicationId; MainActivity.kt package + its directory; the buildSrc Kotlin directory; gen/android app/.gitignore generated-sources path. - strings.xml app_name / main_activity_title were still "CodeDeck Next" -> "CodeDeck+" (this is the launcher label). - MeshSection.tsx WD_GRANT_CMD (a real `adb pm grant` string) and a stale tauri-plugin-mesh manifest comment (which had `com.codedeck.app`). - apps/mobile/README.md reworded to explain the three-way coexistence. - Removed apps/mobile/zapstore.yaml: upstream's Zapstore publish config (their repo, app id, signing identity, a docs/RELEASE.md we don't have). Nothing reads it. Icon: the top ring's inner dot now carries a white "+" (centred on the dot's true centroid). Regenerated every size via `tauri icon`; kept the existing legacy-PNG icon scheme (dropped the desktop/iOS/adaptive-icon files `tauri icon` also emits). Verified with a Docker APK build: `aapt2 dump badging` reports package=com.codedeck.plus, label='CodeDeck+', launchable-activity=com.codedeck.plus.MainActivity. `./codedeck check` green. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Android identifier was still
com.codedeck.next— identical to upstream CodeDeck Next. Consequences:INSTALL_FAILED_UPDATE_INCOMPATIBLE.v0.10.0 has ~0 real installs, so this is the moment to fix it.
App id →
com.codedeck.plusDistinct from both the original CodeDeck (
com.codedeck.app) and upstream CodeDeck Next (com.codedeck.next):tauri.conf.jsonidentifier;gen/android/app/build.gradle.ktsnamespace+applicationId;MainActivity.ktpackage + its directory (git mv); thebuildSrcKotlin directory (git mv);gen/android/app/.gitignoregenerated-sources path.strings.xmlapp_name/main_activity_titlewere still "CodeDeck Next" → "CodeDeck+" (this is the launcher label under the icon).MeshSection.tsxWD_GRANT_CMD(a realadb pm grantstring) and a staletauri-plugin-meshmanifest comment (it hadcom.codedeck.app).apps/mobile/README.mdreworded to explain the three-way coexistence.apps/mobile/zapstore.yaml— upstream's Zapstore publish config (their repo, app id, signing identity, adocs/RELEASE.mdwe don't ship). Nothing in the tree reads it.RELEASE_NOTES_0.9.{0,3}.mdkeep theircom.codedeck.nextmentions — accurate history of upstream's releases.Icon
The top ring's inner dot now carries a white "+", centred on the dot's true centroid (found by erosion, since dot and ring share a colour). Regenerated every size with
tauri icon; kept the existing legacy-PNG icon scheme — dropped the desktop.icns/.ico/Square*, theios/set, and themipmap-anydpi-v26adaptive-icon files thattauri iconalso emits (adaptive icons would be a separate change).Verification
./codedeck apk debug) — compiles clean.aapt2 dump badgingon the built APK:package: name='com.codedeck.plus'application-label:'CodeDeck+'launchable-activity: name='com.codedeck.plus.MainActivity'res/mipmap-*/ic_launcher.png./codedeck check— typecheck + 765 mobile tests + the rest, green.Ships in the next release (
v0.11.0— new app id is a user-visible identity change; worth a RELEASE_NOTES entry).Note for later (out of scope):
bundle.android.versionCodeis pinned at6intauri.conf.json, so the APK'sversionCodedoesn't trackversion— fine for a fresh app id, but worth revisiting.