Replace deprecated datetime.utcnow() in AWS MSK IAM client - #3156
Open
utku0dogan wants to merge 1 commit into
Open
Replace deprecated datetime.utcnow() in AWS MSK IAM client#3156utku0dogan wants to merge 1 commit into
utku0dogan wants to merge 1 commit into
Conversation
In Python 3.12+, datetime.datetime.utcnow() is deprecated and scheduled for removal. Replace with datetime.datetime.now(datetime.timezone.utc) and update corresponding unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title:
net/sasl: Replace deprecated datetime.utcnow() with datetime.now(timezone.utc)
PR Description:
Python 3.12+ deprecates
datetime.datetime.utcnow()in favor of timezone-aware UTC datetimes.This PR:
datetime.datetime.utcnow()withdatetime.datetime.now(datetime.timezone.utc)inkafka/net/sasl/msk.py.test/net/sasl/test_msk.pyto match the new signature and removes the obsolete Python 3.3 check.All tests in
test/net/sasl/test_msk.pypass with zero warnings (-W error::Warning).