Skip to content

Replace deprecated datetime.utcnow() in AWS MSK IAM client #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utku0dogan wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −7
Open

Replace deprecated datetime.utcnow() in AWS MSK IAM client #3156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/net/sasl/msk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def __init__(self, host, access_key, secret_key, region, token=None):
self.service = 'kafka-cluster'
self.action = '{}:Connect'.format(self.service)

now = datetime.datetime.utcnow()
now = datetime.datetime.now(datetime.timezone.utc)
self.datestamp = now.strftime('%Y%m%d')
self.timestamp = now.strftime('%Y%m%dT%H%M%SZ')

Expand Down
9 changes: 3 additions & 6 deletions test/net/sasl/test_msk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
import datetime
import json
import sys
from unittest import mock

from kafka.net.sasl.msk import AwsMskIamClient, SaslMechanismAwsMskIam


def client_factory(token=None):
if sys.version_info >= (3, 3):
now = datetime.datetime.fromtimestamp(1629321911, datetime.timezone.utc)
else:
now = datetime.datetime.utcfromtimestamp(1629321911)
now = datetime.datetime.fromtimestamp(1629321911, datetime.timezone.utc)
with mock.patch('kafka.net.sasl.msk.datetime') as mock_dt:
mock_dt.datetime.utcnow = mock.Mock(return_value=now)
mock_dt.timezone.utc = datetime.timezone.utc
mock_dt.datetime.now = mock.Mock(return_value=now)
return AwsMskIamClient(
host='localhost',
access_key='XXXXXXXXXXXXXXXXXXXX',
Expand Down