Repository navigation
Conversation
heartbeat_renews_only_progress_deadline_and_cannot_resurrect_elapsed_authority compared two lease_expires_at strings. Native times are whole milliseconds and serialize without a fraction on a whole second, so a claim lease of ...:26Z sorted after a renewal of ...:26.045Z and the assertion failed about one run in a thousand (train #729, PostgreSQL 17 job 120852521096). The test now parses both and reports the values.
|
Member
Author
|
Folded into #741 (one R0 change set: the test fix plus the CI lanes), so both qualify in one run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #325. Security class: R0 (test only).
Problem
activity_deadlines::heartbeat_renews_only_progress_deadline_and_cannot_resurrect_elapsed_authoritycompared twolease_expires_atvalues as RFC3339 strings.Native times are whole milliseconds, and chrono writes an instant on a whole second without a fraction (
...:26Z). So about one run in a thousand, a claim lease of...:26Zsorts after a later renewal of...:26.045Z, and the assertion fails. It failed this way on train #729's PostgreSQL 17 job 120852521096 (classification: #729 (comment)).Change
The test parses both values and compares the instants, and the assertion message prints both values. No product code changes.
Order
This merges after #729, so #729 does not have to take
mainagain.