Skip to content

Rust #325: compare activity lease renewals as instants, not RFC3339 text #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmcdaniel wants to merge 1 commit into from
Closed

Rust #325: compare activity lease renewals as instants, not RFC3339 text #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions rust/tests/execution/activity_deadlines.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,14 @@ async fn heartbeat_renews_only_progress_deadline_and_cannot_resurrect_elapsed_au
assert_eq!(after.0, initial.0, "Start-to-close deadline remains fixed");
assert!(after.1 > initial.1, "Heartbeat deadline advances");
assert_eq!(after.2, initial.2, "Lifecycle deadline remains fixed");
// Compare instants, not text: a lease on a whole second is written
// without a fraction ("...:26Z"), which sorts after "...:26.045Z".
let instant = |value: &Value| chrono::DateTime::parse_from_rfc3339(value.as_str().unwrap()).unwrap();
assert!(
renewed.1["lease_expires_at"].as_str().unwrap()
> activity["lease_expires_at"].as_str().unwrap()
instant(&renewed.1["lease_expires_at"]) > instant(&activity["lease_expires_at"]),
"{} renews {}",
renewed.1["lease_expires_at"],
activity["lease_expires_at"]
);
let prefix = run_history(&app, &started["workflow_id"], &started["run_id"]).await;
database
Expand Down
Loading