Fix CI validation for PRs targeting master - #339
Merged
Merged
Conversation
master has no plugin modules of its own, so build.yml's build_and_test job hard-fails on scaffold-only PRs (e.g. #338) with "No 'nbm' modules have been detected." It also never ran at all for fork-based PRs, since push events don't fire cross-fork and master had no pull_request trigger. - build.yml: skip build/validate gracefully when pom.xml has no <module> entries instead of failing. - test-generation.yml: add a pull_request trigger for master so PRs (same-repo or fork) get the generation integration test run pre-merge, mirroring master-forge's pr.yml. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
grep -q '<module>' pom.xml matched the placeholder comment (<!-- ... e.g. <module>modules/MyModule</module> ... -->) in the empty <modules> block, so the skip never actually triggered. Check for real module directories under modules/ instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.yml'sbuild_and_testjob hard-fails on scaffold-only PRs targeting master (e.g. Add AGENTS.md, ARCHITECTURE.md, and CONTRIBUTING.md #338) because master's<modules>list is empty by design — it now skips gracefully instead of erroring when no plugin modules are present.test-generation.ymlnow also triggers onpull_requesttargeting master, so PRs (same-repo or fork) get the generation integration test run pre-merge, mirroring thepr.ymlpattern already used onmaster-forge. Previously fork-based PRs to master got no CI at all.Test plan
buildcheck no longer fails on a docs/scaffold-only PR (no<module>entries)test-generationruns and passes on this PR (pull_request-triggered)buildandtest-generationstill behave as before on direct pushes to master and to plugin topic branches🤖 Generated with Claude Code