Skip to content

Fix CI validation for PRs targeting master #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbastian merged 2 commits into from
Sep 20, 2026
+12 −3
Merged

Fix CI validation for PRs targeting master #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f656b3
Fix CI validation for PRs targeting master
mbastian Sep 20, 2026
18bb6fd
Fix build.yml module check to ignore pom.xml's example comment
mbastian Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,9 @@ jobs:
java-version: '17'
distribution: 'temurin'
- name: Build and validate project
run: mvn -B package --file pom.xml
run: |
if [ -z "$(find modules -mindepth 2 -maxdepth 2 -name pom.xml 2>/dev/null)" ]; then
echo "No plugin modules present under modules/; skipping build/validate (see test-generation workflow for scaffold validation)."
exit 0
fi
mvn -B package --file pom.xml
8 changes: 6 additions & 2 deletions .github/workflows/test-generation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@ name: test-generation

# Integration test for the plugin generation process (gephi-maven-plugin's
# generate/validate/build-metadata/create-autoupdate goals). Runs on every
# master commit so a version bump of gephi-maven-plugin in pom.xml is
# regression-tested before real plugin repos pick it up.
# master commit and on PRs targeting master (master has no plugin modules of
# its own, so build.yml's build_and_test can't validate scaffold changes) so
# a version bump of gephi-maven-plugin in pom.xml is regression-tested before
# real plugin repos pick it up.
on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
generation-integration-test:
Expand Down
Loading