Repository navigation
Conversation
Jxxunnn
requested review from
logaretm and
msonnb
and removed request for
a team
October 19, 2026 06:24
Lms24
pushed a commit
that referenced
this pull request
Oct 19, 2026
) Backport of: #25498 ## Differences to the original PR - `packages/browser/test/profiling/integration.test.ts`: the two new tests use v10's existing `import * as Sentry from '@sentry/browser'` style (`Sentry.init`, `Sentry.addIntegration`, etc.) instead of named imports from `../../src/index`. That import block conflicted because v10's test file still uses the namespace import. - Same file: the unsampled-pageload test uses `Sentry.spanToJSON` instead of `spanToStaticSpanJSON`, because `spanToStaticSpanJSON` doesn't exist on v10. Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Lms24
added a commit
that referenced
this pull request
Oct 19, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #25498 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn lint) & (yarn test).Closes #25497
With the
traceprofile lifecycle in@sentry/browser,notifyRootSpanActive()started the profiler for a root span that was already active at setup. It did not check whether that span was sampled. As a result, an unsampled pageload span started UI profiling and sent aprofile_chunk, even withtracesSampleRate: 0.This change returns early in
notifyRootSpanActive()when the root span is not recording. This matches the check in thespanStartlistener.Two tests were added:
traceprofile lifecycle.notifyRootSpanActive()can start the profiler, so the test covers that path directly. It also checks that the second notification from the timeout does not start another profiler.Validation (in
packages/browser):yarn test: 763 tests passed, including the two new testsyarn lint: no errors;oxfmt --checkpassed on the changed filesnotifyRootSpanActive()is disabled