Skip to content

Merge upstream becf853def (sync stage 2 of 2) - #257

Merged
henrychu04 merged 116 commits into
coder-onlyfrom
t3code/sync-upstream-becf853def
Oct 27, 2026
Merged

henrychu04 merged 116 commits into
coder-onlyfrom
t3code/sync-upstream-becf853def

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Stage 2 of the be1d066 → becf853 upstream sync: upstream main from pingdotgg#25324 (new design on by default) through becf853, 112 commits. Stage 1 was #256.

Carried

Cut

Adaptations after the merge commit

  • GitLab merge request summaries now use upstream's read (perf(source-control): pull request previews read only the pull request pingdotgg/t3code#22583). The fork's batched GraphQL summary is removed. The GitLab files are upstream's again apart from the 6 MiB diff cap, and upstream's auto-merge squash test is back.
  • The "open merge requests in T3 Coder" toggle is back on the Diffs page. Upstream defines it in IntegrationsSettings.tsx, which the fork doesn't carry, so the setting openPullRequestLink.ts reads had no UI.
  • coder-only.md updated with the seams.

Verification

  • All typechecks in AGENTS.md pass, as do pnpm knip:check, pnpm build, and vp fmt --check on the changed files.
  • pnpm test:coder passes on the merge commit and again on the final head. Server: 3,188 tests. Web: 3,895 unit and browser tests.
  • Section 6 checks: marker counts, lost upstream lines, unused locals, and lines lost even though both sides kept them. Every remaining hit is a cut surface, a listed seam, or code upstream moved.
  • Smoke tests with mocks: gateway with the helper, signed assets, and the fake-glab merge request smoke. The MR smoke covers list, summary, detail, diff, checks and filter options; the summary now goes through the detail read with no GraphQL calls.
  • The bundled Linux helper boots in a node:24 amd64 container and extracts notebook text.
  • Not done: a live Coder workspace check.

🤖 Generated with Claude Code

t3dotgg and others added 30 commits October 25, 2026 21:52
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s lifetime (pingdotgg#25226)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nd (pingdotgg#25329)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#25317)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#25336)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otices (pingdotgg#25335)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…e crash (pingdotgg#25345)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nstall them by URL

agent-device install-from-source picks the archive type from the download's
filename, and the cache URL has no extension. Device pool workers can now
fetch the dev client straight from the cache instead of the caller uploading
it through the gateway.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Android clients are cached as the bare APK, not a tarball.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#24912)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…24618)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 28 commits October 26, 2026 15:04
…ring a flush (pingdotgg#25653)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hare one visibility observer (pingdotgg#25630)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ep-awake (pingdotgg#25631)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…long thread (pingdotgg#23780)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: nibarAhmed <61316519+nibarAhmed@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
pingdotgg#25526)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…of per-row effects (pingdotgg#25612)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… message (pingdotgg#18359)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…used pages (pingdotgg#25651)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ft's insert point (pingdotgg#25681)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ke on CI (pingdotgg#25664)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er-picker listener (pingdotgg#25667)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ender loop (pingdotgg#25678)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ask drafts (pingdotgg#25684)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… on the composer (pingdotgg#25401)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fects (pingdotgg#25615)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#25682)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… synchronizing effects (pingdotgg#25614)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…25702)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage 2 of the be1d066 -> becf853 sync: 112 upstream commits from pingdotgg#25324
(new design on by default).

Upstream brought the new design by default, settings grouped by concern with
General split into focused pages (pingdotgg#25651), thread state at the end of the
timeline (pingdotgg#25401), "could not load" / "failed to start" screens (pingdotgg#25317,
pingdotgg#25345), app-level theme/toast/chrome services (pingdotgg#25461), chat route commands,
revisioned queries, PR sweep cache release, goal fixes, worktree-deleted
recovery (pingdotgg#18359), and the Claude MCP-registration retry (pingdotgg#25372).

Cut: the evals package (pingdotgg#24635), the multi-account warning (pingdotgg#25475), the
access/browser/devices settings pages, desktop CLI state, telemetry and
T3 Connect fixes, docs/user/faq.md, and mobile e2e tooling. The failed-to-start
screen keeps reload and copyable details without the desktop update button,
triage command, download link, or upstream issue link. Labs has no Beta
(guest links) section. The fork-only useEnvironmentTheme.test.tsx gives way
to upstream's test now that the hook is upstream's.

Coder: marker drops: _chat.tsx (its shortcuts moved to chatRouteCommands.ts,
which carries the seams) and entities.ts (two notes merged into one).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the fork's batched GraphQL summary read (getMergeRequestSummary) for
upstream's getChangeRequestSummary, which reads each merge request's detail
(pingdotgg#22583). The GitLab files are upstream's again apart from the 6 MiB diff cap,
and upstream's auto-merge squash test returns with gitLabMergeRequestJson.test.ts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream's Diffs page renders PullRequestLinksOpenInAppSetting from
IntegrationsSettings.tsx, which the fork does not carry. Define the row in
SettingsPanels.tsx with MR wording so the setting openPullRequestLink.ts already
honours can be changed again, and list it in settings search.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@henrychu04
henrychu04 merged commit 73f7136 into coder-only Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.