Skip to content

Merge upstream ed44f251d8 (#25423 action tools) into coder-only - #259

Merged
henrychu04 merged 3 commits into
coder-onlyfrom
t3code/sync-upstream-ed44f251d8
Oct 27, 2026
Merged

henrychu04 merged 3 commits into
coder-onlyfrom
t3code/sync-upstream-ed44f251d8

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Stage 1 of the sync to upstream e923627: upstream's pingdotgg#25423 (ed44f25) alone, merged with --no-ff onto coder-only (9486780).

What upstream brings

pingdotgg#25423 cuts T3's MCP tool schemas by a third and merges 18 tools into action tools: t3_queue, t3_pending_request, t3_thread_configure, t3_thread_transfer, schedule_task (now also updates), and PR link/unlink moving to the pull-request toolkit. It adds advertisedJsonSchema.

How it lands on the file bridge

  • The bridge catalog and dispatch are built from upstream's toolkits and handlers, so the merged tools reach --list, --schema and calls with no bridge change.
  • Seam: the bridge's --schema prints upstream's compact advertisedJsonSchema. This is what upstream's MCP server advertises (fix(server): all MCP tools now send compact schemas, cutting tool context by 23% pingdotgg/t3code#25790 applies it to every tool).
  • Plan mode follows upstream. The action tools are marked destructive, so plan mode refuses even their read actions, as upstream's Claude plan-mode allowlist dropped them. This is documented in docs/internals/coder-only.md.

Conflicts

  • McpHttpServer and its test, the preview toolkit, toolkits/core.test.ts, and mobile threadActivity stay deleted, because they are cut surfaces.
  • pullRequests/handlers.test.ts keeps the GitCafe cut. It takes upstream's subagent PR-report test, run on a GitLab merge request URL.

Verification

  • Every typecheck in AGENTS.md passes.
  • pnpm test:coder passes. It was run with a real-path TMPDIR for the known ClaudeSkills plugin-order test fails on macOS (/var symlink) #235 macOS failure. One browser test, AttachmentFilePreview.browser.test.tsx, failed under parallel load and passes alone (Tests that flake under full-suite load #236).
  • pnpm knip:check, pnpm build, and vp fmt --check on changed files all pass.
  • Mechanical checks (marker counts, upstream lines missing, both-sides losses) report nothing.
  • Mock smoke: the gateway serves the web client, and the helper answers thread search and pullRequests.filterOptions.
  • Throwaway bridge test (not committed):
    • --list shows the merged tools and none of the old names;
    • --schema t3_queue prints one compact object with an action enum;
    • t3_queue {action:"list"} returns {items:[],nextCursor:null};
    • plan mode answers PlanModeReadOnly.
  • The Linux helper bundle boots in a node:24-bookworm-slim amd64 container: migrations run and __document-text extracts an RTF.

🤖 Generated with Claude Code

t3dotgg and others added 3 commits October 26, 2026 18:49
… into action tools (pingdotgg#25423)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage 1 of the sync to e923627: upstream's pingdotgg#25423 alone, which merges 18 T3
tools into action tools (t3_queue, t3_pending_request, t3_thread_configure,
t3_thread_transfer, schedule_task absorbing update, PR link/unlink moving to
the pull-request toolkit) and adds advertisedJsonSchema.

The bridge catalog builds on upstream's toolkits and handlers, so the merged
tools reach `--list`, `--schema`, and dispatch unchanged.

Conflicts:
- McpHttpServer, its test, the preview toolkit, toolkits/core.test.ts, and
  mobile's threadActivity stay deleted (cut surfaces).
- pullRequests/handlers.test.ts keeps the GitCafe cut and takes upstream's
  subagent PR report test on a GitLab merge request URL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bridge's `--schema` now prints advertisedJsonSchema, the compact schema
upstream's MCP server advertises (pingdotgg#25423, applied to every tool in pingdotgg#25790).
Document that plan mode refuses the new action tools, which upstream marks
destructive, as upstream's Claude plan-mode allowlist dropped them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants