Skip to content

Let delegate_task name its own environment; record the 67661cfbb5 sync's lessons - #267

Merged
henrychu04 merged 2 commits into
coder-onlyfrom
t3code/fable-review-fixes-67661cfbb5
Oct 28, 2026
Merged

henrychu04 merged 2 commits into
coder-onlyfrom
t3code/fable-review-fixes-67661cfbb5

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Follow-ups to the e923627 → 67661cf sync (#262–#266).

delegate_task naming its own environment. Upstream's remoteTarget treats a target.environmentId equal to the caller's own environment as a local task. The stage 2 seam (#263) refused any environmentId, unlike McpToolAccess's seam for the other tools. It now refuses only another environment, and the seams doc says so. This was found by the partial Fable review, which stopped when Fable usage credits ran out; the full review lands in a later PR.

sync.md:

Verification:

  • pnpm typecheck:server passes.
  • OrchestratorMcpService.test.ts and .activity.test.ts pass (39 tests).
  • A throwaway test (not committed) checked both cases: a target naming the caller's own environment reaches the provider check, and one naming another environment gets "This environment cannot reach linked environments."
  • vp fmt --check passes.

🤖 Generated with Claude Code

henrychu04 and others added 2 commits October 28, 2026 07:03
Upstream's remoteTarget treats a target.environmentId equal to the
caller's own environment as a local task. The stage 2 seam refused any
environmentId, unlike McpToolAccess's seam for the other tools; it now
refuses only another environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renamed patches for cut packages, deletion sweeps that break fork-only
tests at runtime, and dependency lines the merge adds back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant