Skip to content

chore: remove distributed_cli service subcommand - #86

Merged
patrickleet merged 1 commit into
mainfrom
chore/remove-distributed-cli
Aug 5, 2026
Merged

chore: remove distributed_cli service subcommand#86
patrickleet merged 1 commit into
mainfrom
chore/remove-distributed-cli

Conversation

@patrickleet

@patrickleet patrickleet commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove hops service (wrapper around distributed_cli)
  • Drop the distributed_cli crate dependency and lockfile entries
  • Document that microservice scaffolding lives in the standalone distributed CLI

Test plan

  • cargo build
  • cargo test (unit + workflow structural tests)
  • hops-cli --help no longer lists service

Summary by CodeRabbit

  • Breaking Changes

    • Removed the service command from hops-cli.
    • Microservice scaffolding is now available through the standalone distributed CLI.
  • Documentation

    • Updated command documentation to include the dory local backend.
    • Clarified that distributed microservice tooling belongs to the standalone CLI.

Microservice scaffolding lives in the standalone distributed CLI now.
Drop the hops service wrapper and the distributed_cli crate dependency.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CLI removes the service command and its distributed_cli integration. The README documents the dory backend and identifies the standalone distributed CLI for microservice scaffolding.

Changes

Distributed service removal

Layer / File(s) Summary
Remove service command wiring
src/main.rs, Cargo.toml
The Service subcommand and dispatch branch are removed. The distributed_cli dependency is removed.
Align command documentation
README.md
The local command now lists the dory backend. The service command documentation is replaced with a reference to the standalone distributed CLI.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the distributed_cli service subcommand.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-distributed-cli

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 89: Update the README’s local cluster setup, supported-backends, and
Homebrew installation statements to consistently include the dory backend.
Clarify that Homebrew installation applies to colima and kind, while dory
requires the dory CLI, and keep the existing backend documentation aligned with
the entry near “Manage a local control plane.”
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 77e1479a-0cdc-4f36-ad91-8b97e6024f6b

📥 Commits

Reviewing files that changed from the base of the PR and between b0a2417 and e7d8768.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml
  • README.md
  • src/main.rs
💤 Files with no reviewable changes (2)
  • src/main.rs
  • Cargo.toml

Comment thread README.md

- `local`
- Manage a local control plane (colima or kind backend), install providers, and bootstrap AWS or GitHub provider auth.
- Manage a local control plane (colima, kind, or dory backend), install providers, and bootstrap AWS or GitHub provider auth.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Align all backend documentation with the new dory entry.

Line 89 lists dory, but earlier text still lists only colima and kind:

  • Line 9: local cluster setup.
  • Line 15: supported local backends.
  • Line 59: installation through Homebrew.

Update those statements. Clarify that Homebrew applies to colima and kind, while the dory backend uses the dory CLI.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 89, Update the README’s local cluster setup,
supported-backends, and Homebrew installation statements to consistently include
the dory backend. Clarify that Homebrew installation applies to colima and kind,
while dory requires the dory CLI, and keep the existing backend documentation
aligned with the entry near “Manage a local control plane.”

@patrickleet
patrickleet merged commit 78c0fef into main Aug 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant