chore: remove distributed_cli service subcommand - #86
Conversation
Microservice scaffolding lives in the standalone distributed CLI now. Drop the hops service wrapper and the distributed_cli crate dependency.
📝 WalkthroughWalkthroughThe CLI removes the ChangesDistributed service removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 89: Update the README’s local cluster setup, supported-backends, and
Homebrew installation statements to consistently include the dory backend.
Clarify that Homebrew installation applies to colima and kind, while dory
requires the dory CLI, and keep the existing backend documentation aligned with
the entry near “Manage a local control plane.”
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 77e1479a-0cdc-4f36-ad91-8b97e6024f6b
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
Cargo.tomlREADME.mdsrc/main.rs
💤 Files with no reviewable changes (2)
- src/main.rs
- Cargo.toml
|
|
||
| - `local` | ||
| - Manage a local control plane (colima or kind backend), install providers, and bootstrap AWS or GitHub provider auth. | ||
| - Manage a local control plane (colima, kind, or dory backend), install providers, and bootstrap AWS or GitHub provider auth. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Align all backend documentation with the new dory entry.
Line 89 lists dory, but earlier text still lists only colima and kind:
- Line 9: local cluster setup.
- Line 15: supported local backends.
- Line 59: installation through Homebrew.
Update those statements. Clarify that Homebrew applies to colima and kind, while the dory backend uses the dory CLI.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 89, Update the README’s local cluster setup,
supported-backends, and Homebrew installation statements to consistently include
the dory backend. Clarify that Homebrew installation applies to colima and kind,
while dory requires the dory CLI, and keep the existing backend documentation
aligned with the entry near “Manage a local control plane.”
Summary
hops service(wrapper arounddistributed_cli)distributed_clicrate dependency and lockfile entriesTest plan
cargo buildcargo test(unit + workflow structural tests)hops-cli --helpno longer listsserviceSummary by CodeRabbit
Breaking Changes
servicecommand fromhops-cli.distributedCLI.Documentation
dorylocal backend.