Skip to content

chore: remove distributed_cli service subcommand #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickleet merged 1 commit into from
Aug 5, 2026
+3 −22
Merged

chore: remove distributed_cli service subcommand #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ fern = "0.7.1"
log = "0.4.27"
colored = "3.0.0"
clap = { version = "4.5.35", features = ["derive"] }
distributed_cli = "1.6"
openssl-sys = { version = "0.9.106", optional = true }
flate2 = "1.1.0"
tar = "0.4.44"
Expand Down
7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,14 @@ hops config --help
hops secrets --help
hops validate --help
hops xr --help
hops service --help
```

## Command Areas

`hops-cli` is organized into a few command groups:

- `local`
- Manage a local control plane (colima or kind backend), install providers, and bootstrap AWS or GitHub provider auth.
- Manage a local control plane (colima, kind, or dory backend), install providers, and bootstrap AWS or GitHub provider auth.

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Align all backend documentation with the new dory entry.

Line 89 lists dory, but earlier text still lists only colima and kind:

  • Line 9: local cluster setup.
  • Line 15: supported local backends.
  • Line 59: installation through Homebrew.

Update those statements. Clarify that Homebrew applies to colima and kind, while the dory backend uses the dory CLI.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 89, Update the README’s local cluster setup,
supported-backends, and Homebrew installation statements to consistently include
the dory backend. Clarify that Homebrew installation applies to colima and kind,
while dory requires the dory CLI, and keep the existing backend documentation
aligned with the entry near “Manage a local control plane.”

- `config`
- Build, install, reload, and uninstall Crossplane configuration packages against the connected cluster.
- `secrets`
Expand All @@ -96,8 +95,8 @@ hops service --help
- Generate configuration manifests from Upbound-format XRD projects for validation workflows.
- `xr`
- Observe existing XR-backed infrastructure and render adoption, management, or orphaning manifests.
- `service`
- Scaffold Distributed microservice crates, optional GitOps/Knative/GitHub workflow scaffolds, and inspect/render their project manifests.

Microservice scaffolding previously available as `hops service` now lives in the standalone **distributed** CLI (`distributed` / `distributed_cli`).

## Secrets

Expand Down
5 changes: 0 additions & 5 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ enum Commands {
Config(commands::config::ConfigArgs),
/// Manage Crossplane provider packages in the connected cluster
Provider(commands::provider::ProviderArgs),
/// Create and inspect application services
Service(distributed_cli::ServiceArgs),
/// Manage validation helpers for Crossplane projects
Validate(commands::validate::ValidateArgs),
/// Manage live XR observe/manage/adopt workflows
Expand Down Expand Up @@ -60,9 +58,6 @@ fn main() -> Result<(), Box<dyn Error>> {
Some(Commands::Provider(provider_args)) => {
commands::provider::run(provider_args)?;
}
Some(Commands::Service(service_args)) => {
distributed_cli::run(service_args)?;
}
Some(Commands::Validate(validate_args)) => {
commands::validate::run(validate_args)?;
}
Expand Down
Loading