Skip to content

osd: fix sidebar scale scroll direction #11926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raffi1202 wants to merge 1 commit into
base: maintenance-10.x
Choose a base branch
from
Open

osd: fix sidebar scale scroll direction #11926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/io/osd_grid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,11 @@ static uint16_t osdUpdateSidebar(osd_sidebar_scroll_e scroll, osd_sidebar_t *sid
break;
}
if (offset) {
decoration -= steps % SYM_AH_DECORATION_COUNT;
// Higher symbol codes draw the tick marks lower inside the character cell,
// so adding the steps scrolls the scale down as the value goes up. This
// matches a primary flight display, where climbing or accelerating brings
// the higher numbers down towards the center marker.
decoration += steps % SYM_AH_DECORATION_COUNT;
if (decoration > SYM_AH_DECORATION_MAX) {
decoration -= SYM_AH_DECORATION_COUNT;
} else if (decoration < SYM_AH_DECORATION_MIN) {
Expand Down