Skip to content

osd: fix one byte out-of-bounds write when drawing HUD POIs #11927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raffi1202 wants to merge 1 commit into
base: maintenance-10.x
Choose a base branch
from
+1 −1
Open

osd: fix one byte out-of-bounds write when drawing HUD POIs #11927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/io/osd_hud.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void osdHudDrawPoi(uint32_t poiDistance, int16_t poiDirection, int32_t poiAltitu
uint8_t center_x;
uint8_t center_y;
bool poi_is_oos = 0;
char buff[4];
char buff[5]; // 4 characters plus the terminator osdFormatCentiNumber and tfp_sprintf write at index 4
int altc = 0;

uint8_t minX = osdConfig()->hud_margin_h + 2;
Expand Down