Skip to content

Only consume artifacts from the real firmware workflow #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raffi1202 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Only consume artifacts from the real firmware workflow #11930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-size-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ jobs:
runs-on: ubuntu-latest
if: >
github.event.workflow_run.name == 'Build firmware' &&
github.event.workflow_run.path == '.github/workflows/ci.yml' &&
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success'
concurrency:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr-test-builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
# Only act on pull_request-triggered runs that succeeded.
if: >
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.path == '.github/workflows/ci.yml' &&

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Valid firmware builds are skipped 🐞 Bug ≡ Correctness

Both consumer jobs now require github.event.workflow_run.path to equal the firmware workflow path,
but no repository fixture or convention establishes that this property is populated for
workflow_run events. When the property is absent, the condition evaluates false and valid
pull-request builds are skipped, preventing both artifact consumers from publishing their reports or
builds.
Agent Prompt 
## Issue description
The consumers require `github.event.workflow_run.path`, but the repository does not establish that this property is present in `workflow_run` event payloads. An absent property makes the condition false, so valid pull-request firmware runs do not reach the artifact consumers.

## Fix Focus Areas
- .github/workflows/pr-test-builds.yml[17-20]
- .github/workflows/ci-size-report.yml[138-142]

## Recommended Fix
Replace the path-based guard with a reliably available identifier for the real firmware workflow, such as its workflow ID or another supported discriminator. Preserve the existing pull-request and successful-conclusion checks, and ensure both consumers reject `non-code-change.yaml` without excluding valid `.github/workflows/ci.yml` runs.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

github.event.workflow_run.conclusion == 'success'
# Prevent concurrent runs for the same PR branch racing on the
# release delete/create cycle.
Expand Down
Loading