Conversation
The table had drifted from the source. Index 1 (HW_FAILURE) was missing entirely, so every entry below it was listed one number too low and RX_LOST / RX_LOST_LANDING were swapped. Four names were stale (GYRO_CALIBRATED, ACC_CALIBRATION, ACC_CALIBRATION_FAIL, and two NULL placeholders that are GPS_STATUS and MULTI_BEEPS), and entries 17 to 25 were absent. Numbers, names and patterns now come from beeperTable[] in src/main/io/beeper.c, using the CLI names the beeper command accepts.
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding |
PR Summary by QodoSynchronize buzzer sequence documentation with beeper table
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tone sequence table in
docs/Buzzer.mddoes not matchbeeperTable[]insrc/main/io/beeper.c. Anyone using it to identify a beep gets the wrong answer:HW_FAILURE) is missing entirely. Every entry below it is therefore listed one number too low.RX_LOSTandRX_LOST_LANDINGare swapped. The doc has1 RX_LOST_LANDING/2 RX_LOST; the source has2 RX_LOST/3 RX_LOST_LANDING.GYRO_CALIBRATEDisRUNTIME_CALIBRATION,ACC_CALIBRATIONisACTION_SUCCESS,ACC_CALIBRATION_FAILisACTION_FAIL, and the twoNULLrows areGPS_STATUSandMULTI_BEEPS.SYSTEM_INIT,ON_USB, the threeLAUNCH_MODE*entries, bothCAM_CONNECTION*entries,ALLandPREFERED.The names matter beyond the table: they are what the
beeperCLI command accepts, sobeeper -ACC_CALIBRATIONfrom the docs does not do anything.Change
The table is rebuilt from
beeperTable[]insrc/main/io/beeper.c: index, the CLI name from the entry's name field, and the pattern from the referenced sequence array. Descriptions are kept from the old table where the entry still exists; the new ones are derived from where the source calls them, for exampleACTION_SUCCESSfromconfig.c:382(settings saved),imu.c:829(ACC calibration) andcompass.c:438(compass calibration).Documentation only, no code change.
Test
Not applicable - no code changes. The table was generated by parsing
beeperTable[]and thebeep_*sequence arrays out ofsrc/main/io/beeper.conmaintenance-10.x, then compared entry by entry against the previous table.Flash / RAM
No change: documentation only.
Docs
This PR is the documentation change:
docs/Buzzer.md.