Skip to content

Update flash_m25p16.c - #11953

Open
somethingjustlike wants to merge 1 commit into
iNavFlight:maintenance-9.xfrom
somethingjustlike:ADD-FLASH-ID-IN-9.1.0
Open

somethingjustlike wants to merge 1 commit into
iNavFlight:maintenance-9.xfrom
somethingjustlike:ADD-FLASH-ID-IN-9.1.0

Conversation

@somethingjustlike

Copy link
Copy Markdown
Contributor

GT25Q64EZ and 128EZ are nor flash,so I put their jedec id into the m25p16.c ,and delect the jedec id in w25n.c
GT25Q64EZ H_DS V1.3..pdf
GT25Q128EZ H_DS V1.2..pdf

@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Add GT25Q64EZ and GT25Q128EZ NOR flash support

✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Recognize GT25Q64EZ and GT25Q128EZ devices by their JEDEC identifiers.
• Configure correct geometry for 64-Mbit and 128-Mbit NOR flash variants.
Diagram

graph TD
    A["JEDEC response"] --> B{"Supported ID?"} -->|GT25Q64EZ| C["64 Mbit geometry"]
    B -->|GT25Q128EZ| D["128 Mbit geometry"]
Loading
High-Level Assessment

Extending the existing M25P16-compatible NOR configuration table is the appropriate approach because both devices use the driver's established identification and geometry flow. A separate driver would duplicate existing NOR behavior without providing a meaningful architectural benefit.

Files changed (1) +6 / -0

Enhancement (1) +6 / -0
flash_m25p16.cRegister GT25Q64EZ and GT25Q128EZ JEDEC geometries +6/-0

Register GT25Q64EZ and GT25Q128EZ JEDEC geometries

• Adds JEDEC IDs 0x1C7117 and 0x1C7118 to the supported SPI NOR flash table. Configures 128 and 256 sectors respectively, with 256 pages per sector.

src/main/drivers/flash_m25p16.c

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@somethingjustlike

Copy link
Copy Markdown
Contributor Author

The macOS SITL build failure is unrelated to this PR. The failure occurs in src/main/common/log.c due to -Werror,-Wgnu-folding-constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant