Skip to content

Fix mistyped target macros that silently disable features #11955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 2 commits into from
Sep 17, 2026
Merged

Fix mistyped target macros that silently disable features #11955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa8d74
Fix mistyped target macros that silently disable features
sensei-hacker Sep 15, 2026
aa7fdea
Stop bf2inav converter from emitting dead W25M flash macros
sensei-hacker Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/main/target/AIKONF7/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,6 @@
#define USE_FLASH_M25P16
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PB0
#define USE_FLASH_W25M
#define W25M_SPI_BUS BUS_SPI3
#define W25M_CS_PIN PB0
#define USE_FLASH_W25M02G
#define W25M02G_SPI_BUS BUS_SPI3
#define W25M02G_CS_PIN PB0
#define USE_FLASH_W25M512
#define W25M512_SPI_BUS BUS_SPI3
#define W25M512_CS_PIN PB0
#define USE_FLASH_W25N01G
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PB0
Expand Down
16 changes: 3 additions & 13 deletions src/main/target/BETAFPVF435/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,6 @@
#define USE_FLASH_W25N01G // 1Gb NAND flash support
#define W25N01G_SPI_BUS BUS_SPI2
#define W25N01G_CS_PIN FLASH_CS_PIN
#define USE_FLASH_W25M // Stacked die support
#define W25M_SPI_BUS BUS_SPI2
#define W25M_CS_PIN FLASH_CS_PIN
#define USE_FLASH_W25M512 // 512Kb (256Kb x 2 stacked) NOR flash support
#define W25M512_SPI_BUS BUS_SPI2
#define W25M512_CS_PIN FLASH_CS_PIN
#define USE_FLASH_W25M02G // 2Gb (1Gb x 2 stacked) NAND flash support
#define W25M02G_SPI_BUS BUS_SPI2
#define W25M02G_CS_PIN FLASH_CS_PIN

// *************** OSD *****************************
#define USE_SPI_DEVICE_3
Expand Down Expand Up @@ -143,7 +134,6 @@
#define UART3_TX_PIN PB10
#define USE_UART_INVERTER
#define INVERTER_PIN_UART3_RX PC9
#define INVERTER_PIN_USART3_RX PC9

#define USE_UART4
#define UART4_RX_PIN PA1
Expand All @@ -167,9 +157,9 @@
#define USE_ADC
#define ADC_INSTANCE ADC1
#define ADC1_DMA_STREAM DMA2_CHANNEL5
#define ADC_CHANNEL1_PIN PC2
#define ADC_CHANNEL2_PIN PC1
#define ADC_CHANNEL3_PIN PC0
#define ADC_CHANNEL_1_PIN PC2
#define ADC_CHANNEL_2_PIN PC1
#define ADC_CHANNEL_3_PIN PC0
#define VBAT_ADC_CHANNEL ADC_CHN_1
#define CURRENT_METER_ADC_CHANNEL ADC_CHN_2
#define RSSI_ADC_CHANNEL ADC_CHN_3
Expand Down
9 changes: 0 additions & 9 deletions src/main/target/BROTHERHOBBYF405V3/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,6 @@
#define USE_FLASH_M25P16
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PA15
#define USE_FLASH_W25M
#define W25M_SPI_BUS BUS_SPI3
#define W25M_CS_PIN PA15
#define USE_FLASH_W25M02G
#define W25M02G_SPI_BUS BUS_SPI3
#define W25M02G_CS_PIN PA15
#define USE_FLASH_W25M512
#define W25M512_SPI_BUS BUS_SPI3
#define W25M512_CS_PIN PA15
#define USE_FLASH_W25N01G
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PA15
Expand Down
2 changes: 1 addition & 1 deletion src/main/target/IFLIGHT_H743_AIO_V2/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#define LED0 PC13

#define BEEPER_PIN PD2
#define BEEPER PD2
#define BEEPER_INVERTED

// *************** SPI1 Gyro & ACC *******************
Expand Down
2 changes: 1 addition & 1 deletion src/main/target/JHEH7AIO/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#define LED0 PC13

#define BEEPER_PIN PD15
#define BEEPER PD15
#define BEEPER_INVERTED

// *************** SPI1 Gyro & ACC *******************
Expand Down
9 changes: 0 additions & 9 deletions src/main/target/PRINCIPIOTF7/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@
#define USE_FLASH_M25P16
#define M25P16_SPI_BUS BUS_SPI2
#define M25P16_CS_PIN PB12
#define USE_FLASH_W25M
#define W25M_SPI_BUS BUS_SPI2
#define W25M_CS_PIN PB12
#define USE_FLASH_W25M02G
#define W25M02G_SPI_BUS BUS_SPI2
#define W25M02G_CS_PIN PB12
#define USE_FLASH_W25M512
#define W25M512_SPI_BUS BUS_SPI2
#define W25M512_CS_PIN PB12
#define USE_FLASH_W25N01G
#define W25N01G_SPI_BUS BUS_SPI2
#define W25N01G_CS_PIN PB12
Expand Down
2 changes: 1 addition & 1 deletion src/main/target/RADIOLINKF405/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@

#define MAX_PWM_OUTPUT_PORTS 8

#define USE_SERIAL_3WAY_BLHELI_INTERFACE
#define USE_SERIAL_4WAY_BLHELI_INTERFACE
#define USE_DSHOT
#define USE_DSHOT_DMAR
#define USE_ESC_SENSOR
Expand Down
3 changes: 0 additions & 3 deletions src/utils/bf2inav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,9 +468,6 @@ def writeTargetH(folder, map):
# TODO: add more drivers
suppored_flash_chips = [
'M25P16',
'W25M',
'W25M02G',
'W25M512',
'W25N01G',
'W25N02K',
]
Expand Down
Loading