Conversation
The description of motor_pwm_protocol still offers ONESHOT42 and DSHOT1200. Both were dropped in July 2021 - 4713d58 and d42e5ad - and the values the setting actually accepts have been STANDARD, ONESHOT125, MULTISHOT, BRUSHED, DSHOT150, DSHOT300 and DSHOT600 ever since. It reads straight into docs/Settings.md, so the reference documentation has been advertising two protocols that no firmware since then will accept. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full |
PR Summary by QodoRemove obsolete motor protocols from settings documentation
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motor_pwm_protocol's description still listsONESHOT42andDSHOT1200. Both were removed in July 2021 - 4713d58 "Drop OneShot42" and d42e5ad "Drop DSHOT1200" - and the values the setting accepts have beenSTANDARD, ONESHOT125, MULTISHOT, BRUSHED, DSHOT150, DSHOT300, DSHOT600ever since.The description is what generates
docs/Settings.md, so the reference documentation has spent four years offering two protocols that no firmware built since then will accept. Setting either givesInvalid valuewith the real list, so nothing is broken - it just sends people looking for something that is not there.Documentation only; no functional change.
🤖 Generated with Claude Code