Repository navigation
Conversation
The command now accepts one optional start point with -b and validates that it resolves to a commit. The scene draws the target history when needed, places the new branch and HEAD at the target, and keeps the original branch at its previous commit. Remote-tracking start points receive a remote label and an upstream explanation. The command title, CLI help, and README include the new argument. Fixes initialcommit-com#109 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Contributor
|
Hi @mvanhorn, thx for submitting this! Your timing is actually incredibly funny in a way, since I just pushed a large update to git-sim earlier today, releasing v0.4.0 which overhauls git-sim in multiple major ways that I believe make it a significantly better tool. That being said, I don't believe the checkout -b takes the start point argument which is the purpose of this PR. Would you mind upgrading to git-sim v0.4.0 (latest on main) and resubmitting the PR against that version of the codebase? I appreciate your time and contribution, and would love to get that fix merged in with you as the contributor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command now accepts one optional start point with -b and validates that it resolves to a commit. Users cannot give checkout -b a commit, branch, or tag to start the new branch from.
The scene and validation test run passed all 48 tests, including the added abbreviated-commit checkout test, with one deprecation warning.
Fixes #109