Repository navigation
Conversation
Add a remappable Shift+Z shortcut for the workflow editor and panel. Reveal the target view and move focus while preserving the panel mode.
github-actions
Bot
added
frontend
joshistoast
left a comment
joshistoast
left a comment
There was a problem hiding this comment.
Otherwise, the approach is contained, reuses existing infrastructure, and adds meaningful tests without apparent performance concerns. It provides useful navigation, though narrower than the original issue’s edit/linear-mode toggle.
| const opened = openWidgetPlacement({ | ||
| getWidgetsForRegion, | ||
| options: { preferredRegions: [destination] }, | ||
| projectId: project.id, | ||
| typeId: 'workflow', | ||
| widgets, | ||
| }); |
There was a problem hiding this comment.
[P2] Shift+Z can hide the Workflow panel it starts from.
Reproduce by starting in Compose, adding Workflow to the left panel, then pressing Shift+Z. Opening the missing center graph reuses the left panel’s instance. The reducer then switches the left panel to another widget or collapses it. A focus-navigation shortcut unexpectedly removes the companion form.
Preserve the left panel when opening the graph, and add regression coverage for this layout. The existing test misses it because the default Workflow layout uses separate instances.
Open a separate workflow graph instance from the Compose panel. Cover the focus round trip and preserve the panel in custom layouts.
joshistoast
left a comment
joshistoast
left a comment
There was a problem hiding this comment.
your last commit almost fixed it.
| const opened = openWidgetPlacement({ | ||
| getWidgetsForRegion, | ||
| options: { preferredRegions: [destination] }, | ||
| projectId: project.id, | ||
| typeId: 'workflow', | ||
| widgets, | ||
| }); |
There was a problem hiding this comment.
[P2] Revealing an existing graph still hides the left Workflow panel.
Reproduction:
- Start in Compose and press
4to open Workflow. - Enable Workflow in the left rail.
- Select Preview in the center.
- Focus left Workflow and press Shift+Z.
The existing graph bypasses the new fix. Opening it reuses the shared instance, switching the left panel to another widget or collapsing it. The new tests cover only a missing graph.
Select the existing center Workflow tab directly so a shared panel stays open.
|
Thanks for catching this, @joshistoast. The latest commit ( Could you take another look when you have a chance? |
Summary
Press Shift+Z in the workflow graph editor or the left Workflow panel to move keyboard focus to the other view. The shortcut reveals a collapsed destination and can be changed in Settings → Hotkeys under Switch workflow view.
Related Issues / Discussions
Related to #6429.
QA Instructions
4to open Workflow, enable Workflow in the left rail, then select Preview in the center. Focus the left Workflow panel and press Shift+Z twice. The existing graph opens alongside the original panel without adding another Workflow tab. The second press returns focus to the panel.pnpm check:releasepassed formatting, lint, and types. The unit stage hit the same two macOS shortcut assertions on this branch and the clean base. The remaining release stages did not run.Review
The shortcut preserves the panel's selected tab and form mode. When both docked graph views are visible, focus returns to the center graph. A floating editor stays in place when there is no left Workflow panel to switch to.
Checklist
What's Newcopy (if doing a release after this PR)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.