Repository navigation
feat: add SAIC_REGION=br for MG iSMART LATAM (Brazil) - #597
Merged
Merged
Conversation
2 tasks done
joszz
force-pushed
the
feat/saic-region-br
branch
2 times, most recently
from
November 12, 2026 20:01
55fdccf to
7772975
Compare
joszz
reviewed
Nov 12, 2026
joszz
left a comment
Owner
There was a problem hiding this comment.
Thanks for this, and for the careful write-up in #594.
I checked the change against the current main:
docker/resolve-saic-rest-uri.shresolveseu,au,trandbrto their endpoints, leaves an unknown region empty, falls back toeuwhenSAIC_REGIONis unset, and an explicitSAIC_REST_URIstill wins.- Every place that lists the regions is updated: both READMEs,
CONFIGURATION.md,.env.exampleand both entries inunraid/garagestack.xml. Nothing else in the repository depends on the list. - It merges cleanly with
main.
One small point, not a blocker: the comment at the top of resolve-saic-rest-uri.sh names the "API Endpoints" table in the saic-python-mqtt-gateway README as the source of truth, and that table does not list Brazil until SAIC-iSmart-API/saic-python-mqtt-gateway#527 is merged. A short note in the comment (for example that br comes from that PR and the other projects you linked in #594) would keep a later reader from removing it as unknown.
After merge, the Unraid template change needs the sync to joszz/unraid-community-apps, and your offer to open that PR is welcome.
🤖 Generated with Claude Code
joszz
enabled auto-merge
November 12, 2026 20:04
joszz
disabled auto-merge
November 12, 2026 20:04
joszz
force-pushed
the
feat/saic-region-br
branch
from
November 12, 2026 20:10
7772975 to
b6c4b5f
Compare
joszz
enabled auto-merge
November 12, 2026 20:13
Maps SAIC_REGION=br to https://gateway-mg-br.soimt.com/api.app/v1/ in resolve-saic-rest-uri.sh and lists it next to eu, au and tr in the README, the all-in-one README, CONFIGURATION.md, .env.example and the Unraid template. Checked with the all-in-one image (0.15.1) on an MG4 Urban in Brazil: the gateway logs in, registers the alarm switches and polls the vehicle and charging status, and the telemetry reaches the dashboard. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joszz
force-pushed
the
feat/saic-region-br
branch
from
November 12, 2026 20:15
b6c4b5f to
440b730
Compare
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Maps
SAIC_REGION=brtohttps://gateway-mg-br.soimt.com/api.app/v1/indocker/resolve-saic-rest-uri.shand listsbrnext toeu,auandtrinREADME.md,docker/all-in-one/README.md,documentation/CONFIGURATION.md,.env.exampleandunraid/garagestack.xml. An explicitSAIC_REST_URIstill wins, as before.Transparency: I am a Brazilian MG4 Urban owner, not an expert on the SAIC API. Claude helped me with the investigation and this change, and it can make mistakes. Details of what I tested and its limits are in the linked issue.
How I checked it
SAIC_REGIONset toeu,au,trandbrand to an unknown value, and with an explicitSAIC_REST_URI: each region resolves to its endpoint, an unknown region leaves it empty, and the explicit value wins.0.15.1withSAIC_REST_URIset to the Brazil endpoint andSAIC_REGION=br, on an MG4 EV URBAN in Brazil with a secondary account: the gateway logged in and the telemetry reached the dashboard. (I setSAIC_REST_URIby hand in that run; I did not rebuild the image with this patch.)unraid/garagestack.xmlstill parses as XML.Type of Change
Related Issues
Closes #594
Checklist
pnpm lint/dotnet build) (no frontend or .NET code changed;shellcheckwas not available to me)unraid/garagestack.xmlchanged: it will need syncing tojoszz/unraid-community-appsafter merge, through a pull request there (see "Keeping the Community Apps copy in sync" indocumentation/RELEASING.md). I can open that PR if you want.🤖 Generated with Claude Code