Skip to content

fix avdl names for chat since it's not released yet - #5004

Merged
songgao merged 5 commits into
masterfrom
songgao/avdl-fix-1202
Dec 6, 2016
Merged

songgao merged 5 commits into
masterfrom
songgao/avdl-fix-1202

Conversation

@songgao

@songgao songgao commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

r? @mmaxim @maxtaco Thanks!

Comment thread go/chat/sender_test.go
TopicID: []byte{0},
},
TLFMessage: chat1.MessageBoxed{
TlfMessage: chat1.MessageBoxed{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer TLFMessage on the go side here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means tLFMessage in avdl per @gabriel 's linter. But I guess we could add special handling for TLF and ID. What do you think @gabriel?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I way prefer TlfMessage over tLFMessage.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For TLFMessage: keybase/node-avdl-compiler#10 PTAL Thanks!

@keybase-ci-visdiff

Copy link
Copy Markdown

The commits abed0df...9723ad1 introduce visual changes on linux.

🔎 1 changed

@keybase-ci-visdiff

Copy link
Copy Markdown

The commits abed0df...9723ad1 introduce visual changes on linux.

🔎 1 changed

@keybase-ci-visdiff

Copy link
Copy Markdown

The commits abed0df...f6595a3 introduce visual changes on linux.

🔎 1 changed

@songgao
songgao merged commit 299b2fb into master Dec 6, 2016
@songgao
songgao deleted the songgao/avdl-fix-1202 branch December 6, 2016 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants