Renumber the issue 572 evaluation to ADR-0130 and fix its pointer to the corpus - #672
Merged
Merged
Conversation
…rpus work that has since merged Two pull requests landed close together and both took the number 0129. The design of experiments record (#668) merged first, so the issue 572 evaluation (#670) moves to 0130 and the references in ADR-0123 follow it. The evaluation also said the tools it used had been committed to a branch in the benchmark corpus and never merged. That was true when it was written and is not now. They merged as BNGL-Models PR 47, so both records now say where the files are rather than where they were missing from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pull requests landed close together and both took ADR number 0129. The design of experiments
record (#668) merged first, so the issue 572 evaluation (#670) moves to 0130. The references in
ADR-0123 follow it.
The evaluation also said the tools it used had been committed to a branch in the benchmark corpus
and never merged. That was true when it was written and stopped being true a few minutes later,
when wshlavacek/BNGL-Models#47 merged. Both records now say where the files are rather than where
they were missing from, and point at wshlavacek/BNGL-Models#48 for the additions.
No other change.