Skip to content

Preserve full pay --wait events - #334

Merged
benthecarman merged 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-11-pay-wait-events
Nov 12, 2026
Merged

benthecarman merged 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-11-pay-wait-events

Conversation

@tankyleo

@tankyleo tankyleo commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
    Preserve full pay --wait events

    Users need BOLT12 invoices to generate payer proofs later and failure
    reasons to diagnose unsuccessful payments. Neither can currently be
    recovered from payment history, making the completion event the
    opportunity to retain this information.

    Co-Authored-By: Codex

and

    Serialize payment failure reasons as enum names

    Numeric failure reasons make payment failures difficult to diagnose.

    Co-Authored-By: Codex

Users need BOLT12 invoices to generate payer proofs later and failure
reasons to diagnose unsuccessful payments. Neither can currently be
recovered from payment history, making the completion event the
opportunity to retain this information.

Co-Authored-By: Codex
@ldk-reviews-bot

ldk-reviews-bot commented Nov 11, 2026 •

Copy link
Copy Markdown

👋 Thanks for assigning @vincenzopalazzo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Comment thread ldk-server-cli/src/pay_wait.rs Resolved
Numeric failure reasons make payment failures difficult to diagnose.

Co-Authored-By: Codex
@tankyleo
tankyleo force-pushed the 2026-11-pay-wait-events branch from 7ec35b2 to 155b7b4 Compare November 12, 2026 00:16
@benthecarman
benthecarman merged commit dcbd46a into lightningdevkit:main Nov 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants