Bump http-client-csharp TCGC dependency to 0.71.2 - #11739
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
commit: |
Jorge Rangel (jorgerangel-msft)
left a comment
There was a problem hiding this comment.
Copilot we need to address the spector tests failures. Re-generate all the test libraries as well
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Regenerated all test libraries and committed the resulting generated reference update in |
Jorge Rangel (jorgerangel-msft)
left a comment
There was a problem hiding this comment.
Copilot we need to regenerate all the test libraries as there are still CI failures:
D:\a\_work\1\s\packages\http-client-csharp\eng\scripts\Test-Packages.ps1 : Generated code is not up to date. Please run: eng/Generate.ps1
At D:\a\_work\_temp\1eda050a-e80f-4721-b1e6-07ae746c28a1.ps1:4 char:1
+ . 'D:\a\_work\1\s\packages\http-client-csharp\eng\scripts\Test-Packag …
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Test-Packages.ps1
##[error]PowerShell exited with code '1'.
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Regenerated the full test-library set and traced the Windows-only failure to the generated package README, which Linux had emitted under different casing. Committed the missing README update in |
There was a problem hiding this comment.
Pull request overview
Updates the @typespec/http-client-csharp package to use @azure-tools/typespec-client-generator-core (TCGC) 0.71.2, and applies the corresponding decorator-scope migration required by the newer TCGC behavior.
Changes:
- Bumps
@azure-tools/typespec-client-generator-coreto0.71.2in both peer + dev deps and refreshespackage-lock.json. - Migrates
@convenientAPI/@protocolAPIusages in sample TypeSpec projects and unit tests to include the"csharp"scope argument. - Updates the
api-versionoption documentation wording for multi-service / namespace maps.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/content/docs/docs/emitters/clients/http-client-csharp/reference/emitter.md | Updates api-version option documentation wording for multi-service version selection. |
| packages/http-client-csharp/readme.md | Mirrors the api-version documentation update in the package README. |
| packages/http-client-csharp/package.json | Bumps TCGC peer + dev dependency versions to 0.71.2. |
| packages/http-client-csharp/package-lock.json | Refreshes lockfile entries for the TCGC 0.71.2 bump. |
| packages/http-client-csharp/generator/TestProjects/Plugin/Sample-TypeSpec/Sample-TypeSpec.tsp | Adds "csharp" scope to @convenientAPI / @protocolAPI usages in plugin sample TypeSpec. |
| packages/http-client-csharp/generator/TestProjects/Local/Sample-TypeSpec/Sample-TypeSpec.tsp | Adds "csharp" scope to @convenientAPI / @protocolAPI usages in local sample TypeSpec. |
| packages/http-client-csharp/emitter/test/Unit/usage.test.ts | Updates in-test TypeSpec snippets to include "csharp" scope for @convenientAPI. |
| packages/http-client-csharp/emitter/test/Unit/operation-paging.test.ts | Updates paging unit test TypeSpec snippets to include "csharp" scope for @convenientAPI. |
Files not reviewed (1)
- packages/http-client-csharp/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
You can try these changes here
|
Updates
http-client-csharpto TCGC 0.71.2 and regenerates its libraries.Dependencies
package-lock.json.Decorator migration
"csharp"scope to@convenientAPIand@protocolAPIusages.