Skip to content

Add localizable strings for --check headless validation#14578

Open
kuchungmsft wants to merge 1 commit into
microsoft:mainfrom
kuchungmsft:dev/kuchung/check-native-strings
Open

Add localizable strings for --check headless validation#14578
kuchungmsft wants to merge 1 commit into
microsoft:mainfrom
kuchungmsft:dev/kuchung/check-native-strings

Conversation

@kuchungmsft

Copy link
Copy Markdown
Contributor

Add localizable strings for --check headless validation

Adds 13 native strings backing the mscppls --check mode (the clangd-style
headless validation of a compile_commands.json file): the two --help entries
and the setup/usage error messages.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new localizable strings in nativeStrings.json to support headless --check validation messaging and help text for related CLI options.

Changes:

  • Adds localized help text for --check and --check-compile-commands usage.
  • Adds localized error/status strings for common --check validation failure cases (missing source, missing/discovery failures for compile_commands.json, read/open/timeouts, etc.).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"check_requires_source": {
"text": "--check requires a source file: --check=<file>",
"hint": "{Locked=\"--check\"} {Locked=\"--check=<file>\"}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuchungmsft File should not be locked. It is a placeholder and not a literal, so it should be translated.

},
"check_compile_commands_not_discovered": {
"text": "could not find compile_commands.json in any parent directory of {0}; pass --check-compile-commands=<path> to specify it explicitly",
"hint": "{0} is the starting directory path. {Locked=\"compile_commands.json\"} {Locked=\"{0}\"} {Locked=\"--check-compile-commands=<path>\"}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to use Copilot to check for any other cases were we might be incorrectly locking a placeholder string which should be translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Request

Development

Successfully merging this pull request may close these issues.

3 participants