-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add localizable strings for --check headless validation #14578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kuchungmsft
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
kuchungmsft:dev/kuchung/check-native-strings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -698,5 +698,54 @@ | |
| "status_indexing_files_with_text": "Indexing files {0}", | ||
| "help_allow_missing_lsp_config": "Allow the server to start even if the specified --lsp-config file does not exist.", | ||
| "initialize_failed_during_engine_setup": "Initialization failed during engine setup.", | ||
| "important_label": "Important:" | ||
| } | ||
| "important_label": "Important:", | ||
| "help_check": { | ||
| "text": "Validate a source file against compile_commands.json by fully parsing and analyzing it, reporting any diagnostics. Exits non-zero if errors are found.", | ||
| "hint": "{Locked=\"compile_commands.json\"}" | ||
| }, | ||
| "help_check_compile_commands": { | ||
| "text": "Path to a specific compile_commands.json (or its directory) to use with --check. Defaults to auto-discovery.", | ||
| "hint": "{Locked=\"compile_commands.json\"} {Locked=\"--check\"}" | ||
| }, | ||
| "check_not_authorized": { | ||
| "text": "not authorized; sign in is required to run --check", | ||
| "hint": "{Locked=\"--check\"}" | ||
| }, | ||
| "check_requires_source": { | ||
| "text": "--check requires a source file: --check=<file>", | ||
| "hint": "{Locked=\"--check\"} {Locked=\"--check=<file>\"}" | ||
| }, | ||
| "check_source_not_found": { | ||
| "text": "source file not found: {0}", | ||
| "hint": "{0} is the source file path. {Locked=\"{0}\"}" | ||
| }, | ||
| "check_compile_commands_not_found": { | ||
| "text": "compile_commands.json not found: {0}", | ||
| "hint": "{0} is the file path. {Locked=\"compile_commands.json\"} {Locked=\"{0}\"}" | ||
| }, | ||
| "check_compile_commands_not_discovered": { | ||
| "text": "could not find compile_commands.json in any parent directory of {0}; pass --check-compile-commands=<path> to specify it explicitly", | ||
| "hint": "{0} is the starting directory path. {Locked=\"compile_commands.json\"} {Locked=\"{0}\"} {Locked=\"--check-compile-commands=<path>\"}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Feel free to use Copilot to check for any other cases were we might be incorrectly locking a placeholder string which should be translated. |
||
| }, | ||
| "check_engine_init_failed": "failed to initialize the language engine", | ||
| "check_no_workspace_folder": { | ||
| "text": "no workspace folder resolved for {0}", | ||
| "hint": "{0} is the source file path. {Locked=\"{0}\"}" | ||
| }, | ||
| "check_not_in_compile_commands": { | ||
| "text": "{0} is not present in {1}", | ||
| "hint": "{0} is the source file path. {1} is the compile_commands.json path. {Locked=\"{0}\"} {Locked=\"{1}\"}" | ||
| }, | ||
| "check_read_failed": { | ||
| "text": "failed to read {0}", | ||
| "hint": "{0} is the file path. {Locked=\"{0}\"}" | ||
| }, | ||
| "check_open_failed": { | ||
| "text": "failed to open {0} for analysis", | ||
| "hint": "{0} is the source file path. {Locked=\"{0}\"}" | ||
| }, | ||
| "check_timed_out": { | ||
| "text": "timed out waiting for analysis of {0} to finish", | ||
| "hint": "{0} is the source file path. {Locked=\"{0}\"}" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuchungmsft File should not be locked. It is a placeholder and not a literal, so it should be translated.